Tidy up #519
Merged
Tidy up #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccoVeille
reviewed
Aug 19, 2024
| @@ -82,7 +82,7 @@ func TestAttemptWithDelay(t *testing.T) { | |||
| }) | |||
|
|
|||
| is.Equal(iter1, 1) | |||
| is.Greater(dur1, 0*time.Millisecond) | |||
| is.GreaterOrEqual(dur1, 0*time.Millisecond) | |||
There was a problem hiding this comment.
How could be invalid?
I mean this test will always pass. A duration is always positive, no?
There was a problem hiding this comment.
Could be my hardware or the fact that I'm running on Windows, but for me the first call to AttemptWithDelay (which succeeds immediately) returns within the minimum monotonic time period, so these tests always fail.
| @@ -187,7 +187,7 @@ func TestAttemptWhileWithDelay(t *testing.T) { | |||
| }) | |||
|
|
|||
| is.Equal(iter1, 1) | |||
| is.Greater(dur1, 0*time.Millisecond) | |||
| is.GreaterOrEqual(dur1, 0*time.Millisecond) | |||
|
Wow. That much?? Me, trying to write documentation in English before the Github Copilot era: |
|
(tests are broken) |
|
Were you aware that I'm Australian before posting that gif? 😛 Don't worry, we don't take ourselves too seriously! |
|
Ahah, sorry. I missed that little detail. 😳 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor tidy up - mostly spelling, grammar, newline inconsistencies, trailing whitespace, redundant types, etc.