Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/partition in 2 #499

Closed
wants to merge 2 commits into from
Closed

Conversation

dsolerh
Copy link

@dsolerh dsolerh commented Jul 18, 2024

I find PartitionIn2By useful in the scenarios that I described in the doc comment of the function.
also this is my first PR into this repo, let me know if anything is not complaint with the style, I'm more than willing to fix it.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.46%. Comparing base (6ade78c) to head (664ed38).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #499      +/-   ##
==========================================
+ Coverage   94.44%   94.46%   +0.02%     
==========================================
  Files          17       17              
  Lines        2700     2711      +11     
==========================================
+ Hits         2550     2561      +11     
  Misses        148      148              
  Partials        2        2              
Flag Coverage Δ
unittests 94.46% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samber
Copy link
Owner

samber commented Jul 18, 2024

In your case, I would suggest calling lo.FilterReject.

See also #434

I'm closing this PR. Please open it again if you think I'm wrong and if PartitionIn2By would be valuable to the community!

@samber samber closed this Jul 18, 2024
@dsolerh
Copy link
Author

dsolerh commented Jul 20, 2024

I totally agree with you, I didn't saw the FilterReject before, that's on me, thanks for the time dedicated to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants