Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-funk included when vendoring due to usage in benchmark #50

Closed
jondot opened this issue Mar 20, 2022 · 5 comments · Fixed by #284
Closed

go-funk included when vendoring due to usage in benchmark #50

jondot opened this issue Mar 20, 2022 · 5 comments · Fixed by #284

Comments

@jondot
Copy link

jondot commented Mar 20, 2022

Hi,
Moving from go-funk to lo, just noticed go-funk is still included in my dependency graph, probably due to it being a dependency for the benchmark suite in lo.
Not sure, but is there any way to remove it from the 'release' lib?
@wirekang
Copy link
Contributor

wirekang commented Apr 21, 2022 •
edited
Loading

Have you tried go mod tidy?

@samber
Copy link
Owner

samber commented Apr 22, 2022

Many libraries are added: testify (+ dependencies), go-funk (+ dependencies)...

I agree with you, we should distribute a clean release of this library.

I think the best way to achieve it, is to move test files into a dedicated module.

@sergeykonkin
Copy link

sergeykonkin commented Nov 18, 2022 •
edited
Loading

Hey guys. Just checked on this and I don't see any test dependecies in vendored packages (probably due to module graph pruning introduced in 1.17 https://go.dev/ref/mod#graph-pruning)

image

@samber
Copy link
Owner

samber commented Nov 20, 2022

Did you check go.sum ?

@sergeykonkin
Copy link

Yeah, my bad. go.sum contains all deps:

image

@samber samber mentioned this issue Dec 15, 2022
Merged
@samber samber closed this as completed Dec 15, 2022
samber added a commit to samber/mo that referenced this issue Dec 15, 2022
@samber
chore(ci): add release script + cleanup dependencies before release (…
7fd634e 
…see samber/lo#50)
samber added a commit to samber/do that referenced this issue Dec 15, 2022
@samber
chore(ci): add release script + cleanup dependencies before release (…
d02bc17 
…see samber/lo#50)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: clean-up dependencies on release samber/lo
4 participants
@jondot @samber @sergeykonkin @wirekang