Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Update ALT Linux grains #66694

Closed
wants to merge 1 commit into from
Closed

Conversation

Kanade-py
Copy link

In #3472 added grains for ALT Linux. It is a bit outdated since ALT Linux has now the /etc/os-release file. So core.py now first parses that file, and only if the /etc/os-release file does not exist, it will parse /etc/altlinux-release.

The reason to set os_family to Alt is ALT Linux uses apt-rpm (Apt working with RPM package manager). So RedHat for os_family is not fully suitable. Also, AltLinux based on specific Sisyphus repo and toolset.

What does this PR do?

Adds:

  • Definition of osfullname for ALTLinux.
  • Changes os_family for ALTLinux from RedHat to Alt.

Commits signed with GPG?

No

In #3472 added grains for ALT Linux. It is a bit outdated since ALT Linux has now the /etc/os-release file. So core.py now first parses that file, and only if the /etc/os-release file does not exist, it will parse /etc/altlinux-release.

The reason to set os_family to Alt is ALT Linux uses apt-rpm (Apt working with RPM package manager). So RedHat for os_family is not fully suitable. Also, AltLinux based on specific Sisyphus repo and toolset.
@Kanade-py Kanade-py requested a review from a team as a code owner July 5, 2024 14:24
@Kanade-py Kanade-py requested a review from Akm0d July 5, 2024 14:24
Copy link

welcome bot commented Jul 5, 2024

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at [email protected]. We’re glad you’ve joined our community and look forward to doing awesome things with you!

Copy link
Contributor

@dmurphy18 dmurphy18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog and tests before PR can be accepted

@Kanade-py Kanade-py closed this by deleting the head repository Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants