[Draft] Initial removal of distutils and replacement with setuptools #63255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmurphy18
requested review from
garethgreenaway and
waynew
and removed request for
a team and
garethgreenaway
dmurphy18
changed the title
dmurphy18
force-pushed
the
dgm_dstutils_removal
branch
from
2891be6
to
8345f24
Compare
I was able to build a wheel of Salt and install it under an arch linux vm and run salt master/minion and run some modules. There are a lot of questions going on here, but it's promising!
dmurphy18
force-pushed
the
dgm_dstutils_removal
branch
from
8345f24
to
b6a9e50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? Removes use of distutils and replaces its usage with setuptools
What issues does this PR fix or reference?
Fixes: #60476
Previous Behavior
Could use python setup.py sdist | install | clean and eggs
New Behavior
Need to use build to generate sdist tar ball and wheels
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.