Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nova module cooperation with python-novaclient #49977

Merged
merged 4 commits into from
Oct 11, 2018
Merged

Fix nova module cooperation with python-novaclient #49977

merged 4 commits into from
Oct 11, 2018

Conversation

slivik
Copy link
Contributor

@slivik slivik commented Oct 10, 2018

What does this PR do?

Fixes nova module and salt.utils.openstack.nova module:

  • fixed Keystone API v3 cooperation
  • added Keystone API version detection (based on HTTP status 301 - multiple choices)
  • removed novaclient max version restriction

Previous Behavior

It was not possible to use nova module when python-novaclient > 6.0.1 installed.

New Behavior

Now nova module works with newer version of python-novaclient.

Tests written?

Yes

Commits signed with GPG?

Yes

@ghost ghost self-requested a review October 10, 2018 14:31
gtmanfred
gtmanfred approved these changes Oct 10, 2018
View reviewed changes
Copy link
Contributor

@gtmanfred gtmanfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the help here.

We have also moved everything over to the newer openstack shade module starting in 2018.3. but this would be good to backport to 2017.7

@gtmanfred gtmanfred added the bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch label Oct 10, 2018
@rallytime
Copy link
Contributor

@slivik The pylint check found some errors. Can you fix those?

@rallytime rallytime merged commit 97e859b into saltstack:develop Oct 11, 2018
@rallytime
Copy link
Contributor

@slivik This won't back-port cleanly to the 2017.7 branch. Would you be willing to make this change there as well?

@rallytime rallytime removed the bugfix-bckport will be be back-ported to an older release branch by creating a PR against that branch label Oct 15, 2018
@slivik
Copy link
Contributor Author

slivik commented Oct 18, 2018 •
edited
Loading

@rallytime I have created new PR adding openstack nova module and fixing possibility to back-port it cleanly to the 2017.7 branch.

@Akm0d Akm0d mentioned this pull request Oct 17, 2019
Merged
@Akm0d Akm0d added the has master-port port to master has been created label Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cachedout cachedout cachedout left review comments

@gtmanfred gtmanfred gtmanfred approved these changes

Assignees
No one assigned
Labels
has master-port port to master has been created
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@slivik @rallytime @cachedout @gtmanfred @Akm0d