Backport tojson filter from #48309 to 2018.3 #48339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These should be replaced with "tojson".
|
Looks good, could use some more tests if this is replacing the current jinja JSON filter. |
|
@dijit It doesn't replace it, if the installed version of Jinja has a I'm curious what other tests you think could be added, though. The unit test I added was pretty straightforward. |
rallytime
approved these changes
Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This filter is a superior way to dump data structures into SLS and is less problematic than
json_encode_dict, which A) doesn't emit actual JSON, and B) emits strings as bytestrings, which would cause an error in Python 3.