Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a object interface to __salt__ & __pillar__ (pyobjects) #10600

Merged
merged 3 commits into from
Feb 20, 2014

Conversation

borgstrom
Copy link
Contributor

This is another suggestion from @mgwilliams. It adds an object to the
sls file scope named Salt, which dispatches its attributes to the
__salt__ dictionary.

For example, the following two lines are functionally the same:

ret = Salt.cmd.run(bar)
ret = salt['cmd.run'](bar)

This is another suggestion from @mgwilliams. It adds an object to the
sls file scope named Salt, which dispatches its attributes to the
__salt__ dictionary.

For example, the following two lines are functionally the same:

    ret = Salt.cmd.run(bar)
    ret = salt['cmd.run'](bar)
@ghost
Copy link

ghost commented Feb 20, 2014

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1631/

@ghost
Copy link

ghost commented Feb 20, 2014

Test FAILed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1645/

@ghost
Copy link

ghost commented Feb 20, 2014

Test PASSed.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/1646/

@borgstrom
Copy link
Contributor Author

@thatch45 think this could get cherry picked into 2014.1 as well?

I have plans to make pyobjects work for reactor files but I think we can save that for the next release.

@thatch45
Copy link
Contributor

We tagged 2014.1.0 yesterday (packagers have been notified and we are announcing it on Monday), and we don't have pyobjects in 2014 at all since it was well past feature freeze. If you want this in 2014.1.1 let me know, but I don;t like adding things like this in point releases

thatch45 added a commit that referenced this pull request Feb 20, 2014
Adding a object interface to __salt__ & __pillar__ (pyobjects)
@thatch45 thatch45 merged commit 7a3bf8a into saltstack:develop Feb 20, 2014
@borgstrom
Copy link
Contributor Author

No worries then, I misunderstood the PR when pyobjects was added -- I thought it was going to be added to 2014.1. If not then we'll just wait and it'll go out altogether.

@borgstrom borgstrom deleted the pyobjects_saltobject branch February 20, 2014 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants