Fix overwriting Minion config from temporarily directory #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It fixes the Bootstrap behavior when specified temporarily configuration directory (
-c) with Minion config there.What issues does this PR fix or reference?
Fixes another case for the issue #957 explained below.
Previous Behavior
If a Minion config file is already present on target system (i.e.
/etc/salt/minion), it wouldn't be overwritten from temp dir even with-F(force overwrite option), but only with-C(config-only mode).New Behavior
A Minion config file will be overwritten from temp dir if specified either
-For-Coption.