Remove support for openSUSE Leap 42.2 #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leap 42.2 is EOL and has been replaced by 42.3 This commit also simplifies some of the logic in checking for suse versions. openSUSE 13.X is no longer supported and hasn't been for some time, so we don't need to worry about checking for those versions any longer. The script will bail out at the `__check_end_of_life_versions` functions early on in the install process.
rallytime
force-pushed
the
remove-42.2-leap
branch
from
f493c51
to
14959e0
Compare
|
LTGM!! Improvement over my conservatives update in #1244. Approved! btw, I don't have write access on this repo. |
vutny
reviewed
Jul 12, 2018
| @@ -266,7 +266,7 @@ Red Hat family | |||
| SUSE family | |||
| ~~~~~~~~~~~ | |||
|
|
|||
| - openSUSE Leap 42.2/42.3 | |||
| - openSUSE Leap 42.3 | |||
There was a problem hiding this comment.
I guess Leap releases 15.0 and 15.1 are missing here, since the script attempts to proceed on them when detected.
There was a problem hiding this comment.
Yeah, I am working on 15 support today. @noelmcloughlin Made some improvements there already, but I am making it a bit more robust with git support, etc. So I will update the README about that in another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leap 42.2 is EOL and has been replaced by 42.3
This commit also simplifies some of the logic in checking for suse versions.
openSUSE 13.X is no longer supported and hasn't been for some time, so we don't need to worry about checking for those versions any longer. The script will bail out at the
__check_end_of_life_versionsfunctions early on in the install process.I will have a couple more changes coming in today for some other suse support items, but this is a good start and is a discrete change that can be it's own PR.
@noelmcloughlin You've been working in this space recently. Can you review this one?