Add Python3 package support for Ubuntu 16.04 #1238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vutny
approved these changes
Jun 2, 2018
There was a problem hiding this comment.
Looks good to me overall, but haven't tested it myself.
Great job @rallytime .
README.rst
Outdated
| @@ -277,6 +277,9 @@ Ubuntu and derivatives | |||
| - KDE neon (based on Ubuntu 16.04) | |||
| - Linux Mint 17/18 | |||
| - Ubuntu 14.04/16.04 and subsequent non-TLS releases (see below) | |||
| - Python3 (see ``-x`` option): | |||
|
|
|||
| - Ubuntu 16.04 | |||
There was a problem hiding this comment.
This looks little bit confusing... I think we could add separate section to the README covering a status of Py3 support.
There was a problem hiding this comment.
That's a better idea. I will fix that. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support to bootstrap to install Salt's Python 3 packages for Ubuntu 16.04 using the
-xoption:What issues does this PR fix or reference?
Refs #1127
Previous Behavior
Could not install Salt with Python 3 packages.
New Behavior
Can now install Salt with Python 3 packages
@vutny Can you review this one?