Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install swig30 as freebsd dep instead of swig. #1191

Merged
merged 1 commit into from
Jan 4, 2018

Conversation

abednarik
Copy link
Contributor

Looks like swig was removed from FreeBSD Ports. See https://www.freshports.org/commit.php?category=devel&port=swig13&files=yes&[email protected]

What does this PR do?

Install swig30 package instead of swig

What issues does this PR fix or reference?

No

Previous Behavior

Salt fails to install in FreeBSD

       pkg: No packages available to install matching 'swig' have been found in the repositories

        * ERROR: Failed to run install_freebsd_git_deps()!!!

       salt-call: not found

       No salt-minion installed, install must have failed!!

       salt_install = bootstrap

       salt_url = http://bootstrap.saltstack.org

New Behavior

Salt installs just fine

@abednarik abednarik force-pushed the freebsd_swig_package branch 2 times, most recently from ee5113d to 89f7c46 Compare January 4, 2018 12:39
@@ -1,4 +1,4 @@
#!/bin/sh -
/#!/bin/sh -
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this additional slash intentional? ;)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad. Fixed.

@abednarik
Copy link
Contributor Author

Looks like I did a squash and is no longer signed with my gpg. Let me see how I can fix that

@abednarik
Copy link
Contributor Author

Please let me know if there anything else I can do. Since we use FreeBSD, our Pipelines are broken and we need to do dirty workarounds to install salt.

Thanks.

@rallytime rallytime merged commit 4bf59ab into saltstack:develop Jan 4, 2018
@rallytime
Copy link
Contributor

@abednarik Merged - thank you for updating the support for this!

@abednarik
Copy link
Contributor Author

Thanks to you @rallytime !

@abednarik
Copy link
Contributor Author

HI @rallytime

Sorry to bother, do you have an idea when this patch will released? We still have hacks everywhere to install our FreeBSD servers.

Thanks.

@rallytime
Copy link
Contributor

We just very recently did a bootstrap release, so it probably wont be for a month or so. However, you can pull down the version in develop and use the patched version. If you're using salt-cloud, you just place it in the /etc/salt/cloud.deploy.d/ directory and it will pick up the version you put in there.

@abednarik abednarik deleted the freebsd_swig_package branch January 24, 2018 22:08
@abednarik abednarik restored the freebsd_swig_package branch January 24, 2018 22:08
@abednarik
Copy link
Contributor Author

Hi @rallytime

This is still an issue. Do you plan to merge this to master and release a new version? Looks like this one didn't went to stable in the last merge.

Thanks.

@rallytime
Copy link
Contributor

Hi @abednarik Yes, I still plan to merge this into stable and release a new version. I got busy with the 2018.3.0 release for salt and this took a back seat. I'm working on slating some time to release in the next week or so. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants