-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install swig30 as freebsd dep instead of swig. #1191
Conversation
ee5113d
to
89f7c46
Compare
bootstrap-salt.sh
Outdated
@@ -1,4 +1,4 @@ | |||
#!/bin/sh - | |||
/#!/bin/sh - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this additional slash intentional? ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, my bad. Fixed.
89f7c46
to
fbd309d
Compare
Looks like I did a squash and is no longer signed with my gpg. Let me see how I can fix that |
Looks like swig was removed from FreeBSD Ports. See https://www.freshports.org/commit.php?category=devel&port=swig13&files=yes&[email protected]
fbd309d
to
94b86f2
Compare
Please let me know if there anything else I can do. Since we use FreeBSD, our Pipelines are broken and we need to do dirty workarounds to install salt. Thanks. |
@abednarik Merged - thank you for updating the support for this! |
Thanks to you @rallytime ! |
HI @rallytime Sorry to bother, do you have an idea when this patch will released? We still have hacks everywhere to install our FreeBSD servers. Thanks. |
We just very recently did a bootstrap release, so it probably wont be for a month or so. However, you can pull down the version in develop and use the patched version. If you're using salt-cloud, you just place it in the |
Hi @rallytime This is still an issue. Do you plan to merge this to master and release a new version? Looks like this one didn't went to stable in the last merge. Thanks. |
Hi @abednarik Yes, I still plan to merge this into stable and release a new version. I got busy with the 2018.3.0 release for salt and this took a back seat. I'm working on slating some time to release in the next week or so. Thanks! |
Looks like swig was removed from FreeBSD Ports. See https://www.freshports.org/commit.php?category=devel&port=swig13&files=yes&[email protected]
What does this PR do?
Install swig30 package instead of swig
What issues does this PR fix or reference?
No
Previous Behavior
Salt fails to install in FreeBSD
New Behavior
Salt installs just fine