make salt-syndic optional on salt bootstrap #1190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vutny
approved these changes
Jan 2, 2018
rallytime
approved these changes
Jan 2, 2018
|
Thank you @sybix and welcome! I love seeing new contributors jump into fixing bootstrap. :) |
|
Any plans to rebase https://bootstrap.saltstack.com to include this pull request? Without these fixes, the bootstrap script reliably fails on Alpine Linux (we use Alpine Linux for quick testing). |
|
@bbczeuz The script in bootstrap.saltstack.com will be updated when we do a release. We will hopefully be able to do that in the next couple of weeks. Otherwise, you can pull from the develop branch here: https://raw.githubusercontent.com/saltstack/salt-bootstrap/develop/bootstrap-salt.sh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the possibility of bootstraping Alpine Linux without salt-syndic
What issues does this PR fix or reference?
#1188