Declare End-Of-Life for Ubuntu 12.04 LTS #1080
Conversation
This drops support for Ubuntu releases less than 14, including all derivatives based on those releases.
bootstrap-salt.sh
Outdated
|
|
||
| fedora) | ||
| # Fedora lower than 18 are no longer supported | ||
| if [ "$DISTRO_MAJOR_VERSION" -lt 23 ]; then |
There was a problem hiding this comment.
I think 23 is EOL too, so let's make that 24 instead.
Also, can you make the comment line above match? (18 should be 24)
There was a problem hiding this comment.
This change would need an update to the README as well.
There was a problem hiding this comment.
@rallytime I think it would be better if I make a change for Fedora in separate PR just to make things clear and separate concerns.
bootstrap-salt.sh
Outdated
| ;; | ||
|
|
||
| centos) | ||
| # CentOS versions lower than 5 are no longer supported |
There was a problem hiding this comment.
Comment should be lower than 6 for clarity.
There was a problem hiding this comment.
Yeah, I'll fix this and later comments to match real comparisons. Thanks for spotting that!
bootstrap-salt.sh
Outdated
| ;; | ||
|
|
||
| red_hat*linux) | ||
| # Red Hat (Enterprise) Linux versions lower than 5 are no longer supported |
There was a problem hiding this comment.
Same thing here, this should read lower than 6.
bootstrap-salt.sh
Outdated
| ;; | ||
|
|
||
| oracle*linux) | ||
| # Oracle Linux versions lower than 5 are no longer supported |
There was a problem hiding this comment.
Same thing here. There are a couple more below this comment that should be updated as well, but I won't add a comment for each one.
|
@rallytime I've fixed the comments in |
|
@vutny sounds good. thanks! |
What does this PR do?
It drops support for Ubuntu LTS 12.04 which reached EOL at April 28, 2017.
Also, installation on derivatives forked from 12.04 release is no longer possible.
The README has been updated accordingly.
Previous Behavior
Salt installation on Ubuntu 12.04 was possible.
New Behavior
The script notifies a user that Ubuntu 12.04 reached EOL and no longer supported.