Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some INFO: lines not logged #1035

Closed
bewing opened this issue Mar 22, 2017 · 4 comments
Closed

Some INFO: lines not logged #1035

bewing opened this issue Mar 22, 2017 · 4 comments

Comments

@bewing
Copy link

bewing commented Mar 22, 2017

Description of Issue/Question

Some INFO lines are outputted prior to setting up the logging pipe. This means that one cannot review the command line used to call salt-bootstrap.sh in the logfile itself, which would make it easier to re-run salt-bootstrap inside a vagrant vm, for git-based installs, as more commits are pushed.

Versions and Systems

INFO: Running version: 2017.01.10

@rallytime
Copy link
Contributor

Ah, thanks for pointing that out @bewing. We'll have to get that fixed up.

@rallytime
Copy link
Contributor

Hi @bewing - this should be fixed by #1091. Please give that a try if you have a moment.

@bewing
Copy link
Author

bewing commented Jun 9, 2017

Can confirm that this resolves my original issue, and the following line is now in the log:
* INFO: Command line: '/tmp/bootstrap_salt.sh -P -c /tmp -F -c /tmp -k /tmp/minion-seed-keys -M git develop'
and I can copy/paste it and re-run it to my heart's content.

@rallytime
Copy link
Contributor

Thanks for confirming @bewing! The change was just merged into develop and will be available in the next stable release. I'll go ahead and close this.

s0undt3ch added a commit that referenced this issue Jun 16, 2017
Fix #1035: detect and log errors earlier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants