Zabbix proxy sqlitedir - Need help

[xenadmin]

As many people use SQLite for Zabbix proxy, I think it's obvious that the definition of a SQLite in the pillar database has to create the directory. I handled that in a separate state until now, but I find it odd that the official formula has to fail inevitable, because the Zabbix proxy daemon will never launch, because the directory is missing.
But this pull request has a big drawback I think. I someone would like to use a real MySQL or MariaDB, this shouldn't be executed.
I need some kind of IF statement, that will check if dbname contains a word or a path. I wasn't able to fix that yet. If we solve that, this will be a very helpful addition, as the formula will fail otherwise for all SQLite users.

[xenadmin]

Ok so I tested that by defining something not the default for dbname, but my code will still create the folder:
Name: /var/lib/zabbix - Function: file.directory - Result: Clean
But during the same run, will alter the zabbix_proxy.conf:

          ID: /etc/zabbix/zabbix_proxy.conf
    Function: file.managed
      Result: None
     Comment: The file /etc/zabbix/zabbix_proxy.conf is set to be changed
     Started: 21:48:28.513802
    Duration: 305.976 ms
     Changes:   
              ----------
              diff:
                  --- 
                  +++ 
                  @@ -180,7 +180,7 @@
                   # Mandatory: yes
                   # Default:
                   # DBName=
                  -DBName=/var/lib/zabbix/zabbix.sqlite.db
                  +DBName=/var/lib/dummy

[hatifnatt]

@xenadmin yeah it looks like /var/lib/zabbix is not created during zabbix-proxy package installation. I added a simple check for dbname param, if it starts with a / it's most probably a file path, and not a MySQL DB name.

Note I have not tested suggested changes, but I hope everything is correct :)

[xenadmin]

Thank you so much for your help! I love it that this formula gets some love. By now I’m so good with salt, that I manage 33 Zabbix Proxies with it, using 51 states. (If I remember correctly)

Currently I’m on vacation, sorry. Can’t review anything right now. Maybe we can talk in about 10 days?

[xenadmin]

I reviewed your changes @hatifnatt looks good.