fix: support template factory#146
Merged
Merged
Conversation
Member
|
Thanks @buschtoens! If you rebase |
emberjs/ember.js#18096 This PR changed how templates are used under the hood. Template modules now export a factory function that expects to be called with the `owner`.
buschtoens
force-pushed
the
fix/template-factory
branch
from
456bc34 to
42fc271
Compare
Contributor
Author
|
Member
|
Merged and released in v1.2.1! Thanks again @buschtoens 🙂 |
Contributor
Author
|
The pleasure is mine 🎩 |
shahrozAala
pushed a commit
to shahrozAala/ember-switchback
that referenced
this pull request
Oct 24, 2025
* Upgrade dependencies * Upgrade addon * Add glimmer * Fix button submit * Fix Frame * Upgrade FormInput to glimmer * Upgrade TextInput to glimmer * Convert radioset * Convert checkbox * Update Range to glimmer * Convert Rater to glimmer * Remove sparkles * Fixes for glimmer conversion * Fix double header * Fix form validation * Update how events are bound * Fix form tests * Refactor bind-attribute-to-min-width * Refactor bind-attribute into class-based modifier * Fix bind-attribute-min-width size calculation * Fix window being undefined when calling getComputedStyle * Fix element not being defined * Remove double nav * Pin click-addon-docs to master branch * Fix linting * Fix linting * Fix textarea events * Fix fieldset error display * Code review changes * Bump version * Make class-based-modifier a dependency * Upgrade ember-css-modules to deal with template factory layout (see salsify/ember-css-modules#146) * Final 7.0.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emberjs/ember.js#18096
This PR changed how templates are used under the hood. Template modules now export a factory function that expects to be called with the
owner.