fix: incorrect caching for queries participating in fixpoint#843
Merged
MichaReiser merged 1 commit intosalsa-rs:masterfrom May 7, 2025
Merged
fix: incorrect caching for queries participating in fixpoint#843MichaReiser merged 1 commit intosalsa-rs:masterfrom
MichaReiser merged 1 commit intosalsa-rs:masterfrom
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #843 will improve performances by 7.9%Comparing Summary
Benchmarks breakdown
|
Contributor
Author
|
The perf change is interesting, considering that we're invalidating more often but maybe it's because we return |
Contributor
|
@MichaReiser note I rebased this on latest main branch to unblock @dhruvmanila (needed the loom gating fix) |
Member
|
I just checked, this does not fix the hang for us unfortunately. |
Contributor
Author
Hmm, that's sad |
Contributor
Author
|
I created an issue to explore renabling backdating #847 |
Merged
This was referenced May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #836 and may fix the hang in #831
I'm very sorry for not adding any tests but I'm very short on time right now. I'll create an issue if we go ahead with
merging this change to follow up with tests