Skip to content

fix: incorrect caching for queries participating in fixpoint#843

Merged
MichaReiser merged 1 commit intosalsa-rs:masterfrom
MichaReiser:more-fixpoint
May 7, 2025
Merged

fix: incorrect caching for queries participating in fixpoint#843
MichaReiser merged 1 commit intosalsa-rs:masterfrom
MichaReiser:more-fixpoint

Conversation

@MichaReiser
Copy link
Contributor

This is a follow up to #836 and may fix the hang in #831

I'm very sorry for not adding any tests but I'm very short on time right now. I'll create an issue if we go ahead with
merging this change to follow up with tests

@netlify
Copy link

netlify bot commented May 6, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit de69f42
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/681a9776674c7200087d8dff

@MichaReiser MichaReiser added the bug Something isn't working label May 6, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 6, 2025

CodSpeed Performance Report

Merging #843 will improve performances by 7.9%

Comparing MichaReiser:more-fixpoint (de69f42) with master (f8cd8e7)

Summary

⚡ 1 improvements
✅ 11 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
converge_diverge 144.9 µs 134.3 µs +7.9%

@MichaReiser
Copy link
Contributor Author

The perf change is interesting, considering that we're invalidating more often but maybe it's because we return Unchanged for initial

Copy link
Contributor

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@carljm
Copy link
Contributor

carljm commented May 6, 2025

@MichaReiser note I rebased this on latest main branch to unblock @dhruvmanila (needed the loom gating fix)

@Veykril
Copy link
Member

Veykril commented May 7, 2025

I just checked, this does not fix the hang for us unfortunately.

@MichaReiser
Copy link
Contributor Author

I just checked, this does not fix the hang for us unfortunately.

Hmm, that's sad

@MichaReiser
Copy link
Contributor Author

I created an issue to explore renabling backdating #847

@MichaReiser MichaReiser added this pull request to the merge queue May 7, 2025
Merged via the queue into salsa-rs:master with commit f78a641 May 7, 2025
11 checks passed
@MichaReiser MichaReiser deleted the more-fixpoint branch May 7, 2025 07:11
@github-actions github-actions bot mentioned this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants