chore: Include struct name in formatted input-field index#819
Merged
MichaReiser merged 1 commit intosalsa-rs:masterfrom Apr 25, 2025
Merged
chore: Include struct name in formatted input-field index#819MichaReiser merged 1 commit intosalsa-rs:masterfrom
MichaReiser merged 1 commit intosalsa-rs:masterfrom
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #819 will improve performances by 5.37%Comparing Summary
Benchmarks breakdown
|
MichaReiser
force-pushed
the
input-field-index
branch
from
e5832a5 to
56e4e09
Compare
MichaReiser
changed the title
Veykril
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to tracked struct fields, include the struct name in the formatted index of input-fields.
It's not clear to me how to write a test for this because the formatted index is only used in tracing logs.