Closed
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #743 will improve performances by 6.45%Comparing Summary
Benchmarks breakdown
|
Veykril
force-pushed
the
veykril/push-xtnrlstsrzrq
branch
from
97035cb to
9e2a27a
Compare
Veykril
commented
Mar 2, 2025
src/table/sync.rs
Outdated
Comment on lines
22
to
18
| syncs: RwLock<Vec<Option<SyncState>>>, | ||
| syncs: Mutex<Vec<Option<SyncState>>>, |
Member
Author
There was a problem hiding this comment.
We aren't using the read-half of the RwLock
Veykril
force-pushed
the
veykril/push-xtnrlstsrzrq
branch
2 times, most recently
from
3701de8 to
63c14c6
Compare
Member
Author
|
Oof 85a3ff2 makes quite a difference, the event system is certainly not free as it requires us to thread a dyn database handle to a bunch of places just for the event reporting. I wonder if it would be better to have an API that lets you install an event hook into |
Veykril
force-pushed
the
veykril/push-xtnrlstsrzrq
branch
from
85a3ff2 to
f0054dc
Compare
Veykril
force-pushed
the
veykril/push-xtnrlstsrzrq
branch
from
f0054dc to
0283619
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.