perf: Store view downcaster in function ingredients directly #720
+149
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #720 will improve performances by 7.02%Comparing Summary
Benchmarks breakdown
|
Veykril
force-pushed
the
veykril/push-ktqyuntnwvxn
branch
from
f23162c to
8f455b0
Compare
Veykril
commented
Feb 23, 2025
Veykril
force-pushed
the
veykril/push-ktqyuntnwvxn
branch
from
8f455b0 to
d91e86b
Compare
Member
Author
|
The benchmark results are a bit confusing. I think getting rid of the arc-swap stuff might also help making the benches more reliable |
Veykril
force-pushed
the
veykril/push-ktqyuntnwvxn
branch
4 times, most recently
from
80c41b5 to
169a194
Compare
Member
Author
Seems to be more stable with the alloc change now (average green now) |
Veykril
force-pushed
the
veykril/push-ktqyuntnwvxn
branch
from
169a194 to
18d4f9c
Compare
davidbarsky
reviewed
Feb 25, 2025
Veykril
force-pushed
the
veykril/push-ktqyuntnwvxn
branch
2 times, most recently
from
2da5ca3 to
dd26a21
Compare
Member
Author
|
Decent improvement on the accumulator bench |
Veykril
changed the title
nikomatsakis
changed the title
nikomatsakis
approved these changes
Mar 5, 2025
Member
nikomatsakis
left a comment
nikomatsakis
left a comment
There was a problem hiding this comment.
Nice. I don't see any issues.
Veykril
force-pushed
the
veykril/push-ktqyuntnwvxn
branch
from
dd26a21 to
00f8757
Compare
Veykril
force-pushed
the
veykril/push-ktqyuntnwvxn
branch
from
00f8757 to
1772263
Compare
Merged
carljm
added a commit
to carljm/salsa
that referenced
this pull request
Mar 8, 2025
* master: internal: use `portable-atomic` in `IngredientCache` to compile on `powerpc-unknown-linux-gnu` (salsa-rs#749) perf: Store view downcaster in function ingredients directly (salsa-rs#720) perf: Some small perf things (salsa-rs#744)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to skip iterating over all registered view casters whenever we need to cast