Skip to content

Conversation

@MichaReiser
Copy link
Contributor

@MichaReiser MichaReiser commented Feb 21, 2025

Based on #708

Avoid tracking revisions for untracked fields (all tracked fields are covered by the tracked struct's created_at field). This should reduce memory consumption of tracked structs because it avoids tracking unused revisions for untracked field.

Closes #672

@netlify
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit e1884ba
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/67bb5922a1bb270008c7a073

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #709 will not alter performance

Comparing MichaReiser:avoid-tracking-revisions-for-untracked-fields (e1884ba) with master (687251f)

Summary

✅ 9 untouched benchmarks

@MichaReiser MichaReiser force-pushed the avoid-tracking-revisions-for-untracked-fields branch from 027db45 to 779e138 Compare February 23, 2025 16:24
@MichaReiser MichaReiser changed the title avoid tracking revisions for untracked fields Track revisions for tracked-fields only Feb 23, 2025
@MichaReiser MichaReiser force-pushed the avoid-tracking-revisions-for-untracked-fields branch from 779e138 to cc5baaf Compare February 23, 2025 17:18
@MichaReiser MichaReiser force-pushed the avoid-tracking-revisions-for-untracked-fields branch from cc5baaf to e1884ba Compare February 23, 2025 17:21
@MichaReiser MichaReiser marked this pull request as ready for review February 24, 2025 08:25
@Veykril Veykril added this pull request to the merge queue Feb 24, 2025
Merged via the queue into salsa-rs:master with commit a8858a2 Feb 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Avoid tracking revisions for untracked fields

2 participants