LRU eviction at revision bump#684
Merged
Veykril merged 2 commits intosalsa-rs:masterfrom Feb 12, 2025
Merged
Conversation
This change makes us LRU evict once a new revision starts, instead of at the very moment we reach the limit while computing tracked functions. Notably the previous behavior was unsound as we were immediately clearing the value (without going through the delayed deletion buffer) while there could have been outstanding references.
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #684 will not alter performanceComparing Summary
|
MichaReiser
approved these changes
Feb 12, 2025
Callers of these functions need to ensure that the value will be dropped when the revision ends
Veykril
force-pushed
the
veykril/push-xusnvnkytwzu
branch
from
4b84e90 to
f2c9cb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes us LRU evict once a new revision starts, instead of at the very moment we reach the limit while computing tracked functions.