Skip to content

Conversation

@Veykril
Copy link
Member

@Veykril Veykril commented Feb 5, 2025

Fixes #669

@netlify
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit b5882c9
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/67a38f2b754a590008ef376f

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 5, 2025

CodSpeed Performance Report

Merging #673 will not alter performance

Comparing Veykril:veykril/push-zovznokvrpqs (b5882c9) with master (ae416f1)

Summary

✅ 9 untouched benchmarks

@MichaReiser
Copy link
Contributor

Huh, there's a LRU test failure now

@Veykril
Copy link
Member Author

Veykril commented Feb 5, 2025

Ahaha, well the test checks for how many entries are alive via global counter that is decreased on drop. But now we no longer drop them eagerly. So the test is actually wrong in that regard. (my other PR also had to change that)

@Veykril
Copy link
Member Author

Veykril commented Feb 5, 2025

Actually not quite, it was trying to trigger a new revision by creating an input but nowadays that actually doesn't trigger one (only setting an input does)

@Veykril Veykril force-pushed the veykril/push-zovznokvrpqs branch from 46e1953 to b5882c9 Compare February 5, 2025 16:17
@Veykril Veykril added this pull request to the merge queue Feb 5, 2025
Merged via the queue into salsa-rs:master with commit ca9fba4 Feb 5, 2025
8 of 9 checks passed
@Veykril Veykril deleted the veykril/push-zovznokvrpqs branch February 11, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LRU drops memos before revision bump

2 participants