No-op LRU impl for non-lru tracked functions#664
Closed
Veykril wants to merge 3 commits intosalsa-rs:masterfrom
Closed
No-op LRU impl for non-lru tracked functions#664Veykril wants to merge 3 commits intosalsa-rs:masterfrom
Veykril wants to merge 3 commits intosalsa-rs:masterfrom
Conversation
This change allows us to omit LRU state from function ingredients when they don't actually have LRU support.
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #664 will not alter performanceComparing Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows us to omit LRU state from function ingredients when they don't actually have LRU support as well as remove the
Optionwrapping for functions that don't do LRU.This should have a very minor speed and memory improvement in theory as it removes some unnecessary branching and option wrapping.
This was split out of #660