Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace orx-concurrent-vec with boxcar #554

Closed
wants to merge 1 commit into from

Conversation

MichaReiser
Copy link
Contributor

This PR replaces orx-concurrent-vec with boxcar because:

  • boxcar is a much smaller dependency 11.1KB without dependencies vs 90.9KB with a handful of dependencies
  • orx-concurrent-vec fails to build on 32bit platforms (may be fixed soon)
  • boxcar shows better performance

Copy link

netlify bot commented Aug 5, 2024

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 7827ca0
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/66b07052e882460008f7a9b2

Copy link

codspeed-hq bot commented Aug 5, 2024

CodSpeed Performance Report

Merging #554 will not alter performance

Comparing MichaReiser:use-boxcar (7827ca0) with master (7bdf51c)

Summary

✅ 1 untouched benchmarks

@MichaReiser
Copy link
Contributor Author

MichaReiser commented Aug 5, 2024

This gives us a 9% perf improvement. I don't think it's very representative for real world applications, unless the application uses multiple databases

@nikomatsakis we may want to reduce the codspeed threshold to a few percent (2-3?) and change the settings to only comment on improvements/regressions. You can do this on the settings page

@MichaReiser
Copy link
Contributor Author

I close this in favor of #555 which shows even better performance

@MichaReiser MichaReiser closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant