Remove QueryOriginKind::FixpointInitial#1062
Merged
MichaReiser merged 1 commit intosalsa-rs:masterfrom Jan 19, 2026
Merged
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
MichaReiser
force-pushed
the
remove-origin-fixpoint
branch
from
036019a to
7487e8d
Compare
MichaReiser
force-pushed
the
remove-origin-fixpoint
branch
from
7487e8d to
701c078
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a
derivedwith no inputs should give us the same behavior (becausedeep_verify_memofor no dependencies always returnsUnchanged).The only part that I don't feel a 100% sure about is the eviction, which was disabled for fixpoint initial values.
However, it's not clear to me why we wouldn't be able to re-create a fixpoint initial value? Can't we just re-run the query
and it will either create a new fixpiont initial or compute the final result.