Reduce monomorphized code in execute_maybe_iterate#1046
Merged
Veykril merged 2 commits intosalsa-rs:masterfrom Dec 26, 2025
Merged
Reduce monomorphized code in execute_maybe_iterate#1046Veykril merged 2 commits intosalsa-rs:masterfrom
execute_maybe_iterate#1046Veykril merged 2 commits intosalsa-rs:masterfrom
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #1046 will not alter performanceComparing Summary
|
Veykril
approved these changes
Dec 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
execute_maybe_iteratefunction is rather large but not all of its code is generic overC.This PR extracts the not-generic code into a few helper functions to reduce the size of the compiled code.
Before, many functions with cycle handling generated about 8KB of code each (often beeing within the largest functions of the entire
tybinary).This PR reduces the size to about 5KB each (results in a 200KB reduction overall)