Add salsa::Update trait bounds to generics when deriving salsa::Update#1041
Merged
MichaReiser merged 1 commit intosalsa-rs:masterfrom Dec 22, 2025
Merged
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #1041 will degrade performances by 4.01%Comparing Summary
Benchmarks breakdown
|
Contributor
Author
|
We need this to update ty. Happy to address any follow up comments |
Merged
ibraheemdev
reviewed
Dec 22, 2025
Member
ibraheemdev
left a comment
There was a problem hiding this comment.
Looks fine to me, sorry for the late review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support deriving
salsa::Updatefor generic types.We have a few generic types in ty that are used within interned values, for which deriving
salsa::Updatecurrently doesn't work because the derivedsalsa::Updatedoesn't work for allTs, onlyTs that implementsalsa::Update.This PR adds a generic constraint to the
salsa::Updateimplementation to every generic type.