Fix a remainder that was forgotten in #1036

components/salsa-macros/src/interned.rs

@@ -43,7 +43,7 @@ impl AllowedOptions for InternedStruct {
 
     const NO_LIFETIME: bool = true;
 
-    const NON_UPDATE_TYPES: bool = false;
+    const NON_UPDATE_TYPES: bool = true;
 
     const SINGLETON: bool = true;
 

components/salsa-macros/src/options.rs

@@ -268,18 +268,15 @@ impl<A: AllowedOptions> syn::parse::Parse for Options<A> {
                     let content;
                     parenthesized!(content in input);
                     let ident = syn::Ident::parse_any(&content)?;
-                    if ident == "non_update_return_type" {
+                    if ident == "non_update_types" {
                         if let Some(old) = options.non_update_types.replace(ident) {
                             return Err(syn::Error::new(
                                 old.span(),
-                                "option `non_update_return_type` provided twice",
+                                "option `non_update_types` provided twice",
                             ));
                         }
                     } else {
-                        return Err(syn::Error::new(
-                            ident.span(),
-                            "expected `non_update_return_type`",
-                        ));
+                        return Err(syn::Error::new(ident.span(), "expected `non_update_types`"));
                     }
                 } else {
                     return Err(syn::Error::new(

tests/tracked_fn_orphan_escape_hatch.rs

@@ -14,7 +14,7 @@ struct MyInput {
 #[derive(Debug, Clone, Copy, PartialEq, Eq)]
 struct NotUpdate<'a>(PhantomData<fn() -> &'a ()>);
 
-#[salsa::tracked(unsafe(non_update_return_type))]
+#[salsa::tracked(unsafe(non_update_types))]
 fn tracked_fn(db: &dyn salsa::Database, input: MyInput) -> NotUpdate<'_> {
     NotUpdate(PhantomData)
 }