Skip to content

protect against segfault on tests #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sallyom merged 1 commit into from
Feb 24, 2026
Merged

protect against segfault on tests #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pkg/sidecar/proxy/chat_completions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,14 @@ func (s *Server) chatCompletionsHandler(w http.ResponseWriter, r *http.Request)
ctx = context.WithValue(ctx, requestStartTimeKey, requestStart)
r = r.WithContext(ctx)

// Set span attributes with safe defaults for nil values
requestPath := ""
if r.URL != nil {
requestPath = r.URL.Path
}
span.SetAttributes(
attribute.String("llm_d.pd_proxy.connector", s.config.Connector),
attribute.String("llm_d.pd_proxy.request_path", r.URL.Path),
attribute.String("llm_d.pd_proxy.request_path", requestPath),
)

var prefillHostPorts []string
Expand Down
6 changes: 5 additions & 1 deletion pkg/sidecar/proxy/proxy_helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,11 @@ func (s *Server) startHTTP(ctx context.Context, cert *tls.Certificate) error {
// Wrap handler with OpenTelemetry middleware to extract trace context from incoming requests
handler := otelhttp.NewHandler(s.handler, "llm-d-pd-proxy",
otelhttp.WithSpanNameFormatter(func(_ string, r *http.Request) string {
return "llm_d.pd_proxy." + r.Method + " " + r.URL.Path
path := ""
if r.URL != nil {
path = r.URL.Path
}
return "llm_d.pd_proxy." + r.Method + " " + path
}),
)

Expand Down