Skip to content

add default config for cluster-policy-controller#1

Closed
sanchezl wants to merge 2 commits intosallyom:cluster-policy-controller-rbacfrom
sanchezl:cluster-policy-controller-rbac
Closed

add default config for cluster-policy-controller#1
sanchezl wants to merge 2 commits intosallyom:cluster-policy-controller-rbacfrom
sanchezl:cluster-policy-controller-rbac

Conversation

@sanchezl
Copy link

@sanchezl sanchezl commented Oct 8, 2019

@sallyom @deads2k

  1. I've added the bindata/v4.1.0/cluster-policy-controller/defaultconfig.yaml.
  2. Do we add add default config for cluster-policy-controller #1 to the existing config config map (e.g. under a key such as config-cluster-policy.yaml? or create a second config file (e.g. config-cluster-policy)?
  3. Not sure of CI fixes openshift/cluster-kube-controller-manager-operator#2. I have not updated targetconfigcontroller.go to manage the cluster-policy-controller config yet.
  4. bump vendor to include assets and fix broken imports openshift/cluster-kube-controller-manager-operator#3 might result in a dependency on openshiftcontrolplane/v1 is that something we should avoid?

@sallyom sallyom force-pushed the cluster-policy-controller-rbac branch 8 times, most recently from 9ea4a8c to 4ce6ba9 Compare October 15, 2019 00:37
@sallyom sallyom force-pushed the cluster-policy-controller-rbac branch 7 times, most recently from 12aefc3 to 2ed3448 Compare October 18, 2019 18:04
@sanchezl sanchezl closed this Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants