Sh/package version install #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
approved these changes
Sep 29, 2022
WillieRuemmele
approved these changes
Sep 29, 2022
| const pv = new PackageVersion({ connection: this.hubOrg.getConnection(), project: undefined }); | ||
| const results = await pv.createdList({ ...this.flags }); | ||
| const connection = this.hubOrg.getConnection(); | ||
| const results = await PackageVersion.createdList(connection, { ...this.flags }); |
There was a problem hiding this comment.
an even smaller NIT: sometimes we're setting a const connection = this.hubOrg.getConnection and other times we're passing this.hubOrg.getConnection right into the library
There was a problem hiding this comment.
I think most cases we just pass this.hubOrg.getConnection() but in this function the connection was being reused several times so it made sense to assign to a const.
There was a problem hiding this comment.
I figured I probably missed that in the GH diff view, it's really not a big deal :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the plugin with the
PackageVersionrefactoring. ThePackageVersionclass now has more meaningful instance and static functions, rather than a group of utility functions on a class.NOTE: requires forcedotcom/packaging#63 to be merged first.
@W-11819142@
For testing: link the
sh/packageVersionInstallbranch of the packaging library to the plugin, then modify the tsconfig.json files compiler options to force resolution of core and jsforce to the same version.