fix: add end to end build duration and fix version list

salesforcecli · Jun 25, 2024 · 8cfade8 · 8cfade8
1 parent 6a72e0e
commit 8cfade8
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 7 deletions.
diff --git a/messages/package_version_list.md b/messages/package_version_list.md
@@ -153,3 +153,7 @@ Created By
 # language
 
 Language
+
+# endToEndBuildDuration
+
+End To End Build Duration
diff --git a/schemas/package-version-report.json b/schemas/package-version-report.json
@@ -191,6 +191,9 @@
         },
         "AncestorId": {
           "type": ["string", "null"]
+        },
+        "EndToEndBuildDuration": {
+          "type": "number"
         }
       },
       "required": ["HasMetadataRemoved", "Package2", "Version"]

diff --git a/src/commands/package/version/list.ts b/src/commands/package/version/list.ts
@@ -6,7 +6,7 @@
  */
 
 import { Flags, loglevel, orgApiVersionFlagWithDeprecations, SfCommand, Ux } from '@salesforce/sf-plugins-core';
-import { Messages, SfProject } from '@salesforce/core';
+import { Connection, Messages, SfProject } from '@salesforce/core';
 import {
   getContainerOptions,
   getPackageVersionStrings,
@@ -45,7 +45,7 @@ export type PackageVersionListDetails = Omit<
   Alias: string;
   IsOrgDependent: 'N/A' | 'Yes' | 'No';
   CreatedBy: string;
-  ValidatedAsync: boolean;
+  ValidatedAsync?: boolean;
 };
 
 export type PackageVersionListCommandResult = PackageVersionListDetails[];
@@ -195,7 +195,7 @@ export class PackageVersionListCommand extends SfCommand<PackageVersionListComma
           CodeCoverage: codeCoverage,
           HasPassedCodeCoverageCheck: hasPassedCodeCoverageCheck as string | boolean,
           ValidationSkipped: record.ValidationSkipped,
-          ValidatedAsync: record.ValidatedAsync == null ?? false,
+          ValidatedAsync: record.ValidatedAsync,
           AncestorId: record.AncestorId,
           AncestorVersion: ancestorVersion as string,
           Alias: AliasStr,
@@ -208,7 +208,7 @@ export class PackageVersionListCommand extends SfCommand<PackageVersionListComma
         });
       });
       this.styledHeader(`Package Versions [${results.length}]`);
-      this.table(results, getColumnData(flags.concise, flags.verbose, flags['show-conversions-only']), {
+      this.table(results, getColumnData(flags.concise, flags.verbose, flags['show-conversions-only'], connection), {
         'no-truncate': true,
       });
     } else {
@@ -222,7 +222,8 @@ export class PackageVersionListCommand extends SfCommand<PackageVersionListComma
 const getColumnData = (
   concise: boolean,
   verbose: boolean,
-  conversions: boolean
+  conversions: boolean,
+  connection: Connection
 ): Ux.Table.Columns<Record<string, unknown>> => {
   if (concise) {
     return {
@@ -246,12 +247,19 @@ const getColumnData = (
     IsPasswordProtected: { header: messages.getMessage('installKey') },
     IsReleased: { header: 'Released' },
     ValidationSkipped: { header: messages.getMessage('validationSkipped') },
-    ValidatedAsync: { header: messages.getMessage('validatedAsync') },
     AncestorId: { header: 'Ancestor' },
     AncestorVersion: { header: 'Ancestor Version' },
     Branch: { header: messages.getMessage('packageBranch') },
   };
 
+  if (Number(connection.version) > 60) {
+    defaultCols = Object.assign(defaultCols, {
+      ValidatedAsync: {
+        header: messages.getMessage('validatedAsync'),
+      },
+    });
+  }
+
   if (conversions && !verbose) {
     defaultCols = Object.assign(defaultCols, {
       ConvertedFromVersionId: {

diff --git a/src/commands/package/version/report.ts b/src/commands/package/version/report.ts
@@ -120,7 +120,7 @@ export class PackageVersionReportCommand extends SfCommand<PackageVersionReportR
       },
       {
         key: pvlMessages.getMessage('validatedAsync'),
-        value: record.ValidatedAsync == null ?? null,
+        value: record.ValidatedAsync,
       },
       { key: messages.getMessage('ancestorId'), value: record.AncestorId },
       { key: messages.getMessage('ancestorVersion'), value: record.AncestorVersion },
@@ -165,6 +165,10 @@ export class PackageVersionReportCommand extends SfCommand<PackageVersionReportR
         key: plMessages.getMessage('createdBy'),
         value: record.CreatedById,
       },
+      {
+        key: pvlMessages.getMessage('endToEndBuildDuration'),
+        value: record.EndToEndBuildDuration === null ? '' : record.EndToEndBuildDuration?.toFixed(1),
+      },
     ];
     const maximumNumClasses = 15; // Number of least code covered classes displayed on the cli output for better UX.
     let codeCovStr = ''; // String to display when code coverage data is empty or null