Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle more potential nulls #138

Merged
merged 4 commits into from
Jan 12, 2023
Merged

fix: handle more potential nulls #138

merged 4 commits into from
Jan 12, 2023

Conversation

mshanemc
Copy link
Contributor

error from

TypeError: Cannot read properties of null (reading 'type')
Occurred while linting /Users/peter.hale/alm-cli-git/plugin-packaging/src/commands/package/install/report.ts:29
Rule: "sf-plugin/no-unnecessary-properties"

Each property now has ?.type, or another check to ensure it isn't null.

@mshanemc mshanemc requested a review from peternhale January 12, 2023 15:16
@mshanemc mshanemc merged commit 4a36418 into main Jan 12, 2023
@mshanemc mshanemc deleted the sm/handle-more-nulls branch January 12, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternhale peternhale peternhale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mshanemc @peternhale