fix: handle more potential nulls (#138)

* fix: handle more potential nulls * refactor: check node.value at top level * refactor: remove redundant optional * test: ut for static props with no value
salesforcecli · Jan 12, 2023 · 4a36418 · 4a36418
1 parent 922aa2f
commit 4a36418
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/src/rules/no-unnecessary-properties.ts b/src/rules/no-unnecessary-properties.ts
@@ -31,9 +31,10 @@ export const noUnnecessaryProperties = ESLintUtils.RuleCreator.withoutDocs({
           PropertyDefinition(node): void {
             if (
               node.static &&
-              node.key.type === AST_NODE_TYPES.Identifier &&
-              node.parent.type === AST_NODE_TYPES.ClassBody &&
-              node.parent.parent.type === AST_NODE_TYPES.ClassDeclaration &&
+              node.key?.type === AST_NODE_TYPES.Identifier &&
+              node.parent?.type === AST_NODE_TYPES.ClassBody &&
+              node.parent.parent?.type === AST_NODE_TYPES.ClassDeclaration &&
+              node.value &&
               extendsSfCommand(node.parent.parent)
             ) {
               // properties that default to false

diff --git a/test/rules/no-uneccessary-properties.test.ts b/test/rules/no-uneccessary-properties.test.ts
@@ -21,6 +21,14 @@ export default class EnvCreateScratch extends SfCommand<ScratchCreateResponse> {
   public static requiresProject = true
   public static notInTargetList = false
 }
+`,
+    },
+    {
+      name: 'other static properties with no value',
+      code: `
+export default class EnvCreateScratch extends SfCommand<ScratchCreateResponse> {
+  public static org: Org
+}
 `,
     },
     {