Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up usage of null/undefined #380

Merged
merged 17 commits into from
Mar 21, 2024
Merged

clean up usage of null/undefined #380

merged 17 commits into from
Mar 21, 2024

Commits on Mar 13, 2024

  1. Make usage of null/undefined more consistent. 

    Primarily allowing either value for user input.
    @wjhsf
    wjhsf committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    06e5d59 View commit details
    Browse the repository at this point in the history

  2. add explicit return type to canonicalDomain

    @wjhsf
    wjhsf committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    842e129 View commit details
    Browse the repository at this point in the history

  3. add note for weird parse behavior

    @wjhsf
    wjhsf committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    d21c0da View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Update lib/cookie/cookie.ts 

    Co-authored-by: Colin Casey <[email protected]>
    @wjhsf @colincasey
    wjhsf and colincasey committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    c303233 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Merge branch 'master' into nullable

    @wjhsf
    wjhsf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    4ba4af0 View commit details
    Browse the repository at this point in the history

  2. Replace Nullable<T> with more precise T | undefined

    @wjhsf
    wjhsf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    8a83cf8 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into nullable

    @wjhsf
    wjhsf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    523ebb9 View commit details
    Browse the repository at this point in the history

  4. add a bit of breathing room to the file size

    @wjhsf
    wjhsf committed Mar 15, 2024
    Configuration menu
    Copy the full SHA
    681537d View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. Change parse to only return undefined on failure, nut null | undefi… 

    …ned.
    @wjhsf
    wjhsf committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    214dcb0 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Merge branch 'master' into nullable

    @wjhsf
    wjhsf committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4d0b46e View commit details
    Browse the repository at this point in the history

  2. standardize helpers on returning undefined

    @wjhsf
    wjhsf committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    4a97015 View commit details
    Browse the repository at this point in the history

  3. update doc for return type

    @wjhsf
    wjhsf committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    8f614cd View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. change fromJSON to return undefined instead of null

    @wjhsf
    wjhsf committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    ca2be2f View commit details
    Browse the repository at this point in the history

  2. fix incorrect comparison

    @wjhsf
    wjhsf committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    9a54e84 View commit details
    Browse the repository at this point in the history

  3. change date helpers to avoid null, for consistency

    @wjhsf
    wjhsf committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    3fd718e View commit details
    Browse the repository at this point in the history

  4. update fromJSON tests for new return type

    @wjhsf
    wjhsf committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    407233c View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2024

  1. Make test assertions more strict 

    Apply suggestions from code review

Co-authored-by: Colin Casey <[email protected]>
    @wjhsf @colincasey
    wjhsf and colincasey committed Mar 21, 2024
    Configuration menu
    Copy the full SHA
    535d935 View commit details
    Browse the repository at this point in the history