[v5] Update config #269

wjhsf · 2023-03-19T21:52:48Z

I noticed that the class definition for ParameterError is more complex than necessary.

Lines 83 to 90 in 069a7ee

    
           export class ParameterError extends Error { 
        
             constructor(...params: any[]) { 
        
               super(...params); 
        
               if (Object.setPrototypeOf) { 
        
                 Object.setPrototypeOf(this, ParameterError.prototype); 
        
               } 
        
             } 
        
           }

Updating that class definition uncovered a bug that was caused by target: es5 in the tsconfig. Since one of our goals for v5 is to support node 16 as the minimum version, I updated the target to ES2021. This had some knock-on effects, like needing to update the module to support both our new jest tests and old vows tests. I also made a few other tweaks to improve our outputs while I was going through the config.

Targeting ES5 causes the "fixes issue #145" test in cookieJar.spec.ts to fail. Changing the target to the next newest (ES6) requires adding "moduleResolution" to the tsconfig, which then causes issues with using `import` in our TypeScript, but `require` in the legacy vows tests. To support both, we have to bump to a newer version of TypeScript to use the new "node16" module/moduleResolution. (Note: I didn't jump to the _latest_ TypeScript to try to support older projects, as well.)

See: https://huafu.github.io/ts-jest/user/config/isolatedModules

tsconfig.json

package.json

lib/validators.ts

lib/__tests__/ietf.spec.ts

jest.config.js

awaterma

Approved; after discussions.

# Backport This will backport the following commits from `main` to `8.x`: - [Update dependency tough-cookie to v5 (main) (#193107)](https://github.com/elastic/kibana/pull/193107)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) If you want to rebase/retry this PR, check\r\nthis box\r\n\r\n---\r\n\r\nThis PR has been generated by [Renovate\r\nBot](https://github.com/renovatebot/renovate).\r\n\r\n\r\n\r\nCo-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>","sha":"f712e4a47bb653136cc8ceefca08d3524dc00a4b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","💝community","v9.0.0","backport:all-open"],"title":"Update dependency tough-cookie to v5 (main)","number":193107,"url":"https://github.com/elastic/kibana/pull/193107","mergeCommit":{"message":"Update dependency tough-cookie to v5 (main) (#193107)\n\nThis PR contains the following updates:\r\n\r\n| Package | Type | Update | Change |\r\n|---|---|---|---|\r\n| [tough-cookie](https://github.com/salesforce/tough-cookie) |\r\ndevDependencies | major | [`^4.1.4` ->\r\n`^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) |\r\n\r\n---\r\n\r\n### Release Notes\r\n\r\n<details>\r\n<summary>salesforce/tough-cookie (tough-cookie)</summary>\r\n\r\n###\r\n[`v5.0.0`](https://github.com/salesforce/tough-cookie/releases/tag/v5.0.0)\r\n\r\n[Compare\r\nSource](https://github.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0)\r\n\r\n#### Summary\r\n\r\n##### Breaking Changes\r\n\r\n- We've migrated the project to TypeScript! First-party types are now\r\navailable.\r\n- The minimum supported version of node is v18.\r\n- We no longer provide official support for non-node enviroments.\r\n\r\n##### API Changes\r\n\r\n- We've standardized most of our exposed interfaces to accept both\r\n`null` and `undefined` and return only `undefined`.\r\n- `getCookie` and `getCookies` now accept a `string` or `URL` as a\r\nparameter.\r\n- We've removed the `inspect` function in favor of node's\r\n`util.inspect.custom` symbol. Cookies may appear different when logged\r\nin non-node environments.\r\n\r\n##### Other Changes\r\n\r\n- Fixed the expiry time not updating when a cookie is updating.\r\n- Fixed validation errors not getting called in some callbacks.\r\n- [New\r\ndocumentation](https://github.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md)\r\nthat is always kept up to date!\r\n- Performance improvements.\r\n\r\n#### What's Changed\r\n\r\n- Typescript support by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/264](https://github.com/salesforce/tough-cookie/pull/264)\r\n- \\[v5] Update config by [@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/269](https://github.com/salesforce/tough-cookie/pull/269)\r\n- Fix prettier in eslint config by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/274](https://github.com/salesforce/tough-cookie/pull/274)\r\n- Updated dev tooling by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/271](https://github.com/salesforce/tough-cookie/pull/271)\r\n- Port 283 fix to v5 by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/287](https://github.com/salesforce/tough-cookie/pull/287)\r\n- Remove some [@ts-ignore](https://github.com/ts-ignore)\r\ndirectives. by [@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/288](https://github.com/salesforce/tough-cookie/pull/288)\r\n- Clean up validate function. by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/275](https://github.com/salesforce/tough-cookie/pull/275)\r\n- Changes to support full eslint rule configurations by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/289](https://github.com/salesforce/tough-cookie/pull/289)\r\n- Split giant cookie.ts into multiple files. by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/296](https://github.com/salesforce/tough-cookie/pull/296)\r\n- Merge branch 'master' into v5 by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/300](https://github.com/salesforce/tough-cookie/pull/300)\r\n- Merge `v5` into `master` by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/303](https://github.com/salesforce/tough-cookie/pull/303)\r\n- Preparing for release `5.0.0-rc.0` by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/304](https://github.com/salesforce/tough-cookie/pull/304)\r\n- Bump [@babel/traverse](https://github.com/babel/traverse)\r\nfrom 7.21.3 to 7.23.2 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/305](https://github.com/salesforce/tough-cookie/pull/305)\r\n- Configure dependabot and codeowners by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/306](https://github.com/salesforce/tough-cookie/pull/306)\r\n- Bump\r\n[@typescript-eslint/parser](https://github.com/typescript-eslint/parser)\r\nfrom 5.58.0 to 5.62.0 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/310](https://github.com/salesforce/tough-cookie/pull/310)\r\n- Bump eslint-config-prettier from 8.8.0 to 9.0.0 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/311](https://github.com/salesforce/tough-cookie/pull/311)\r\n- Bump async from 2.6.4 to 3.2.4 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/313](https://github.com/salesforce/tough-cookie/pull/313)\r\n- Avoid using `arguments` by [@wjhsf](https://github.com/wjhsf)\r\nin\r\n[https://github.com/salesforce/tough-cookie/pull/316](https://github.com/salesforce/tough-cookie/pull/316)\r\n- Configure dependabot to ignore\r\n[@types/node](https://github.com/types/node). by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/319](https://github.com/salesforce/tough-cookie/pull/319)\r\n- Bump dependencies. by [@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/323](https://github.com/salesforce/tough-cookie/pull/323)\r\n- Bump the dev-dependencies group with 6 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/342](https://github.com/salesforce/tough-cookie/pull/342)\r\n- Bump the dev-dependencies group with 1 update by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/344](https://github.com/salesforce/tough-cookie/pull/344)\r\n- Bump the dev-dependencies group with 3 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/347](https://github.com/salesforce/tough-cookie/pull/347)\r\n- docs: use correct memstore file link by\r\n[@alissonsleal](https://github.com/alissonsleal) in\r\n[https://github.com/salesforce/tough-cookie/pull/349](https://github.com/salesforce/tough-cookie/pull/349)\r\n- Bump the dev-dependencies group with 3 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/351](https://github.com/salesforce/tough-cookie/pull/351)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/354](https://github.com/salesforce/tough-cookie/pull/354)\r\n- Fix expiry time not updating when cookie is updated by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/345](https://github.com/salesforce/tough-cookie/pull/345)\r\n- Change dependabot to monthly by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/355](https://github.com/salesforce/tough-cookie/pull/355)\r\n- Bump the dev-dependencies group with 5 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/358](https://github.com/salesforce/tough-cookie/pull/358)\r\n- Avoid `void` by [@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/331](https://github.com/salesforce/tough-cookie/pull/331)\r\n- Replace `psl` with `tldts` by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/346](https://github.com/salesforce/tough-cookie/pull/346)\r\n- Bump the production-dependencies group with 1 update by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/362](https://github.com/salesforce/tough-cookie/pull/362)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/363](https://github.com/salesforce/tough-cookie/pull/363)\r\n- docs: fix JSON.serialize -> JSON.stringify by\r\n[@zavan](https://github.com/zavan) in\r\n[https://github.com/salesforce/tough-cookie/pull/361](https://github.com/salesforce/tough-cookie/pull/361)\r\n- Remove workarounds for `util` in non-node environments by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/359](https://github.com/salesforce/tough-cookie/pull/359)\r\n- Accept URL parameter in `getCookies` and `setCookie` by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/364](https://github.com/salesforce/tough-cookie/pull/364)\r\n- Remove community cookie store links by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/367](https://github.com/salesforce/tough-cookie/pull/367)\r\n- Handle unlikely edge case in unimportant util by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/366](https://github.com/salesforce/tough-cookie/pull/366)\r\n- Fix allow listed `files` for what to include in npm package by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/368](https://github.com/salesforce/tough-cookie/pull/368)\r\n- fix\r\n[#256](https://github.com/salesforce/tough-cookie/issues/256)\r\nby [@hrueger](https://github.com/hrueger) in\r\n[https://github.com/salesforce/tough-cookie/pull/297](https://github.com/salesforce/tough-cookie/pull/297)\r\n- Preparing for release 5.0.0-rc.1 by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/369](https://github.com/salesforce/tough-cookie/pull/369)\r\n- Bump\r\n[@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)\r\nfrom 6.20.0 to 7.0.0 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/373](https://github.com/salesforce/tough-cookie/pull/373)\r\n- Bump the production-dependencies group with 1 update by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/370](https://github.com/salesforce/tough-cookie/pull/370)\r\n- Fixes eslint plugin dev upgrades by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/375](https://github.com/salesforce/tough-cookie/pull/375)\r\n- restore `parse` export that was accidentally removed by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/376](https://github.com/salesforce/tough-cookie/pull/376)\r\n- Clean up cookie creation by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/381](https://github.com/salesforce/tough-cookie/pull/381)\r\n- Enforce explicit function return type by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/383](https://github.com/salesforce/tough-cookie/pull/383)\r\n- patch removed util methods for vows by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/389](https://github.com/salesforce/tough-cookie/pull/389)\r\n- clean up usage of null/undefined by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/380](https://github.com/salesforce/tough-cookie/pull/380)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/404](https://github.com/salesforce/tough-cookie/pull/404)\r\n- Bump the production-dependencies group with 1 update by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/403](https://github.com/salesforce/tough-cookie/pull/403)\r\n- Remove `@types/psl` from dev dependencies by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/406](https://github.com/salesforce/tough-cookie/pull/406)\r\n- Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group\r\nby [@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/411](https://github.com/salesforce/tough-cookie/pull/411)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/412](https://github.com/salesforce/tough-cookie/pull/412)\r\n- Bump ejs from 3.1.9 to 3.1.10 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/413](https://github.com/salesforce/tough-cookie/pull/413)\r\n- Update v5 docs by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/384](https://github.com/salesforce/tough-cookie/pull/384)\r\n- Enable strict type checked rules by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/392](https://github.com/salesforce/tough-cookie/pull/392)\r\n- Preparing for release 5.0.0-rc.2 by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/414](https://github.com/salesforce/tough-cookie/pull/414)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/417](https://github.com/salesforce/tough-cookie/pull/417)\r\n- Bump [@eslint/js](https://github.com/eslint/js) from 8.57.0\r\nto 9.4.0 by [@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/419](https://github.com/salesforce/tough-cookie/pull/419)\r\n- Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group\r\nacross 1 directory by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/420](https://github.com/salesforce/tough-cookie/pull/420)\r\n- chore: update deps by [@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/421](https://github.com/salesforce/tough-cookie/pull/421)\r\n- Use latest TypeScript version by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/423](https://github.com/salesforce/tough-cookie/pull/423)\r\n- Update contributors by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/425](https://github.com/salesforce/tough-cookie/pull/425)\r\n- Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group\r\nby [@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/426](https://github.com/salesforce/tough-cookie/pull/426)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/427](https://github.com/salesforce/tough-cookie/pull/427)\r\n- Fix validation errors not calling callbacks by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/424](https://github.com/salesforce/tough-cookie/pull/424)\r\n- Preparing for release 5.0.0-rc.3 by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/430](https://github.com/salesforce/tough-cookie/pull/430)\r\n- Remove url-parse and punycode by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/429](https://github.com/salesforce/tough-cookie/pull/429)\r\n- Checks structure instead of instanceof for URL test by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/431](https://github.com/salesforce/tough-cookie/pull/431)\r\n- pre-release cleanup by [@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/428](https://github.com/salesforce/tough-cookie/pull/428)\r\n- Preparing for release 5.0.0-rc.4 by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/432](https://github.com/salesforce/tough-cookie/pull/432)\r\n- use `domainToASCII(str)` instead of `new URL(str).hostName` by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/433](https://github.com/salesforce/tough-cookie/pull/433)\r\n- Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group\r\nby [@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/436](https://github.com/salesforce/tough-cookie/pull/436)\r\n- Bump the dev-dependencies group across 1 directory with 6 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/439](https://github.com/salesforce/tough-cookie/pull/439)\r\n- Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group\r\nby [@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/443](https://github.com/salesforce/tough-cookie/pull/443)\r\n- Bump the dev-dependencies group with 6 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/444](https://github.com/salesforce/tough-cookie/pull/444)\r\n- upgrade typescript-eslint to 8.0.1 by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/440](https://github.com/salesforce/tough-cookie/pull/440)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/448](https://github.com/salesforce/tough-cookie/pull/448)\r\n- Bump eslint from 8.57.0 to 9.9.1 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/449](https://github.com/salesforce/tough-cookie/pull/449)\r\n- Prepare v5 by [@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/451](https://github.com/salesforce/tough-cookie/pull/451)\r\n\r\n#### New Contributors\r\n\r\n- [@alissonsleal](https://github.com/alissonsleal) made their\r\nfirst contribution in\r\n[https://github.com/salesforce/tough-cookie/pull/349](https://github.com/salesforce/tough-cookie/pull/349)\r\n- [@zavan](https://github.com/zavan) made their first\r\ncontribution in\r\n[https://github.com/salesforce/tough-cookie/pull/361](https://github.com/salesforce/tough-cookie/pull/361)\r\n- [@hrueger](https://github.com/hrueger) made their first\r\ncontribution in\r\n[https://github.com/salesforce/tough-cookie/pull/297](https://github.com/salesforce/tough-cookie/pull/297)\r\n\r\n**Full Changelog**:\r\nhttps://github.com/salesforce/tough-cookie/compare/v4.1.3...v5.0.0\r\n\r\n</details>\r\n\r\n---\r\n\r\n### Configuration\r\n\r\n📅 **Schedule**: Branch creation - At any time (no schedule defined),\r\nAutomerge - At any time (no schedule defined).\r\n\r\n🚦 **Automerge**: Disabled by config. Please merge this manually once you\r\nare satisfied.\r\n\r\n♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the\r\nrebase/retry checkbox.\r\n\r\n🔕 **Ignore**: Close this PR and you won't be reminded about this update\r\nagain.\r\n\r\n---\r\n\r\n- [ ] If you want to rebase/retry this PR, check\r\nthis box\r\n\r\n---\r\n\r\nThis PR has been generated by [Renovate\r\nBot](https://github.com/renovatebot/renovate).\r\n\r\n\r\n\r\nCo-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>","sha":"f712e4a47bb653136cc8ceefca08d3524dc00a4b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193107","number":193107,"mergeCommit":{"message":"Update dependency tough-cookie to v5 (main) (#193107)\n\nThis PR contains the following updates:\r\n\r\n| Package | Type | Update | Change |\r\n|---|---|---|---|\r\n| [tough-cookie](https://github.com/salesforce/tough-cookie) |\r\ndevDependencies | major | [`^4.1.4` ->\r\n`^5.0.0`](https://renovatebot.com/diffs/npm/tough-cookie/4.1.4/5.0.0) |\r\n\r\n---\r\n\r\n### Release Notes\r\n\r\n<details>\r\n<summary>salesforce/tough-cookie (tough-cookie)</summary>\r\n\r\n###\r\n[`v5.0.0`](https://github.com/salesforce/tough-cookie/releases/tag/v5.0.0)\r\n\r\n[Compare\r\nSource](https://github.com/salesforce/tough-cookie/compare/v4.1.4...v5.0.0)\r\n\r\n#### Summary\r\n\r\n##### Breaking Changes\r\n\r\n- We've migrated the project to TypeScript! First-party types are now\r\navailable.\r\n- The minimum supported version of node is v18.\r\n- We no longer provide official support for non-node enviroments.\r\n\r\n##### API Changes\r\n\r\n- We've standardized most of our exposed interfaces to accept both\r\n`null` and `undefined` and return only `undefined`.\r\n- `getCookie` and `getCookies` now accept a `string` or `URL` as a\r\nparameter.\r\n- We've removed the `inspect` function in favor of node's\r\n`util.inspect.custom` symbol. Cookies may appear different when logged\r\nin non-node environments.\r\n\r\n##### Other Changes\r\n\r\n- Fixed the expiry time not updating when a cookie is updating.\r\n- Fixed validation errors not getting called in some callbacks.\r\n- [New\r\ndocumentation](https://github.com/salesforce/tough-cookie/blob/v5.0.0/api/docs/tough-cookie.md)\r\nthat is always kept up to date!\r\n- Performance improvements.\r\n\r\n#### What's Changed\r\n\r\n- Typescript support by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/264](https://github.com/salesforce/tough-cookie/pull/264)\r\n- \\[v5] Update config by [@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/269](https://github.com/salesforce/tough-cookie/pull/269)\r\n- Fix prettier in eslint config by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/274](https://github.com/salesforce/tough-cookie/pull/274)\r\n- Updated dev tooling by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/271](https://github.com/salesforce/tough-cookie/pull/271)\r\n- Port 283 fix to v5 by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/287](https://github.com/salesforce/tough-cookie/pull/287)\r\n- Remove some [@ts-ignore](https://github.com/ts-ignore)\r\ndirectives. by [@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/288](https://github.com/salesforce/tough-cookie/pull/288)\r\n- Clean up validate function. by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/275](https://github.com/salesforce/tough-cookie/pull/275)\r\n- Changes to support full eslint rule configurations by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/289](https://github.com/salesforce/tough-cookie/pull/289)\r\n- Split giant cookie.ts into multiple files. by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/296](https://github.com/salesforce/tough-cookie/pull/296)\r\n- Merge branch 'master' into v5 by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/300](https://github.com/salesforce/tough-cookie/pull/300)\r\n- Merge `v5` into `master` by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/303](https://github.com/salesforce/tough-cookie/pull/303)\r\n- Preparing for release `5.0.0-rc.0` by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/304](https://github.com/salesforce/tough-cookie/pull/304)\r\n- Bump [@babel/traverse](https://github.com/babel/traverse)\r\nfrom 7.21.3 to 7.23.2 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/305](https://github.com/salesforce/tough-cookie/pull/305)\r\n- Configure dependabot and codeowners by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/306](https://github.com/salesforce/tough-cookie/pull/306)\r\n- Bump\r\n[@typescript-eslint/parser](https://github.com/typescript-eslint/parser)\r\nfrom 5.58.0 to 5.62.0 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/310](https://github.com/salesforce/tough-cookie/pull/310)\r\n- Bump eslint-config-prettier from 8.8.0 to 9.0.0 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/311](https://github.com/salesforce/tough-cookie/pull/311)\r\n- Bump async from 2.6.4 to 3.2.4 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/313](https://github.com/salesforce/tough-cookie/pull/313)\r\n- Avoid using `arguments` by [@wjhsf](https://github.com/wjhsf)\r\nin\r\n[https://github.com/salesforce/tough-cookie/pull/316](https://github.com/salesforce/tough-cookie/pull/316)\r\n- Configure dependabot to ignore\r\n[@types/node](https://github.com/types/node). by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/319](https://github.com/salesforce/tough-cookie/pull/319)\r\n- Bump dependencies. by [@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/323](https://github.com/salesforce/tough-cookie/pull/323)\r\n- Bump the dev-dependencies group with 6 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/342](https://github.com/salesforce/tough-cookie/pull/342)\r\n- Bump the dev-dependencies group with 1 update by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/344](https://github.com/salesforce/tough-cookie/pull/344)\r\n- Bump the dev-dependencies group with 3 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/347](https://github.com/salesforce/tough-cookie/pull/347)\r\n- docs: use correct memstore file link by\r\n[@alissonsleal](https://github.com/alissonsleal) in\r\n[https://github.com/salesforce/tough-cookie/pull/349](https://github.com/salesforce/tough-cookie/pull/349)\r\n- Bump the dev-dependencies group with 3 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/351](https://github.com/salesforce/tough-cookie/pull/351)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/354](https://github.com/salesforce/tough-cookie/pull/354)\r\n- Fix expiry time not updating when cookie is updated by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/345](https://github.com/salesforce/tough-cookie/pull/345)\r\n- Change dependabot to monthly by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/355](https://github.com/salesforce/tough-cookie/pull/355)\r\n- Bump the dev-dependencies group with 5 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/358](https://github.com/salesforce/tough-cookie/pull/358)\r\n- Avoid `void` by [@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/331](https://github.com/salesforce/tough-cookie/pull/331)\r\n- Replace `psl` with `tldts` by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/346](https://github.com/salesforce/tough-cookie/pull/346)\r\n- Bump the production-dependencies group with 1 update by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/362](https://github.com/salesforce/tough-cookie/pull/362)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/363](https://github.com/salesforce/tough-cookie/pull/363)\r\n- docs: fix JSON.serialize -> JSON.stringify by\r\n[@zavan](https://github.com/zavan) in\r\n[https://github.com/salesforce/tough-cookie/pull/361](https://github.com/salesforce/tough-cookie/pull/361)\r\n- Remove workarounds for `util` in non-node environments by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/359](https://github.com/salesforce/tough-cookie/pull/359)\r\n- Accept URL parameter in `getCookies` and `setCookie` by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/364](https://github.com/salesforce/tough-cookie/pull/364)\r\n- Remove community cookie store links by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/367](https://github.com/salesforce/tough-cookie/pull/367)\r\n- Handle unlikely edge case in unimportant util by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/366](https://github.com/salesforce/tough-cookie/pull/366)\r\n- Fix allow listed `files` for what to include in npm package by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/368](https://github.com/salesforce/tough-cookie/pull/368)\r\n- fix\r\n[#256](https://github.com/salesforce/tough-cookie/issues/256)\r\nby [@hrueger](https://github.com/hrueger) in\r\n[https://github.com/salesforce/tough-cookie/pull/297](https://github.com/salesforce/tough-cookie/pull/297)\r\n- Preparing for release 5.0.0-rc.1 by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/369](https://github.com/salesforce/tough-cookie/pull/369)\r\n- Bump\r\n[@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/eslint-plugin)\r\nfrom 6.20.0 to 7.0.0 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/373](https://github.com/salesforce/tough-cookie/pull/373)\r\n- Bump the production-dependencies group with 1 update by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/370](https://github.com/salesforce/tough-cookie/pull/370)\r\n- Fixes eslint plugin dev upgrades by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/375](https://github.com/salesforce/tough-cookie/pull/375)\r\n- restore `parse` export that was accidentally removed by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/376](https://github.com/salesforce/tough-cookie/pull/376)\r\n- Clean up cookie creation by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/381](https://github.com/salesforce/tough-cookie/pull/381)\r\n- Enforce explicit function return type by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/383](https://github.com/salesforce/tough-cookie/pull/383)\r\n- patch removed util methods for vows by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/389](https://github.com/salesforce/tough-cookie/pull/389)\r\n- clean up usage of null/undefined by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/380](https://github.com/salesforce/tough-cookie/pull/380)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/404](https://github.com/salesforce/tough-cookie/pull/404)\r\n- Bump the production-dependencies group with 1 update by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/403](https://github.com/salesforce/tough-cookie/pull/403)\r\n- Remove `@types/psl` from dev dependencies by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/406](https://github.com/salesforce/tough-cookie/pull/406)\r\n- Bump tldts from 6.1.16 to 6.1.18 in the production-dependencies group\r\nby [@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/411](https://github.com/salesforce/tough-cookie/pull/411)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/412](https://github.com/salesforce/tough-cookie/pull/412)\r\n- Bump ejs from 3.1.9 to 3.1.10 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/413](https://github.com/salesforce/tough-cookie/pull/413)\r\n- Update v5 docs by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/384](https://github.com/salesforce/tough-cookie/pull/384)\r\n- Enable strict type checked rules by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/392](https://github.com/salesforce/tough-cookie/pull/392)\r\n- Preparing for release 5.0.0-rc.2 by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/414](https://github.com/salesforce/tough-cookie/pull/414)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/417](https://github.com/salesforce/tough-cookie/pull/417)\r\n- Bump [@eslint/js](https://github.com/eslint/js) from 8.57.0\r\nto 9.4.0 by [@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/419](https://github.com/salesforce/tough-cookie/pull/419)\r\n- Bump tldts from 6.1.18 to 6.1.24 in the production-dependencies group\r\nacross 1 directory by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/420](https://github.com/salesforce/tough-cookie/pull/420)\r\n- chore: update deps by [@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/421](https://github.com/salesforce/tough-cookie/pull/421)\r\n- Use latest TypeScript version by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/423](https://github.com/salesforce/tough-cookie/pull/423)\r\n- Update contributors by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/425](https://github.com/salesforce/tough-cookie/pull/425)\r\n- Bump tldts from 6.1.28 to 6.1.30 in the production-dependencies group\r\nby [@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/426](https://github.com/salesforce/tough-cookie/pull/426)\r\n- Bump the dev-dependencies group with 4 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/427](https://github.com/salesforce/tough-cookie/pull/427)\r\n- Fix validation errors not calling callbacks by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/424](https://github.com/salesforce/tough-cookie/pull/424)\r\n- Preparing for release 5.0.0-rc.3 by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/430](https://github.com/salesforce/tough-cookie/pull/430)\r\n- Remove url-parse and punycode by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/429](https://github.com/salesforce/tough-cookie/pull/429)\r\n- Checks structure instead of instanceof for URL test by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/431](https://github.com/salesforce/tough-cookie/pull/431)\r\n- pre-release cleanup by [@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/428](https://github.com/salesforce/tough-cookie/pull/428)\r\n- Preparing for release 5.0.0-rc.4 by\r\n[@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/432](https://github.com/salesforce/tough-cookie/pull/432)\r\n- use `domainToASCII(str)` instead of `new URL(str).hostName` by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/433](https://github.com/salesforce/tough-cookie/pull/433)\r\n- Bump tldts from 6.1.32 to 6.1.37 in the production-dependencies group\r\nby [@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/436](https://github.com/salesforce/tough-cookie/pull/436)\r\n- Bump the dev-dependencies group across 1 directory with 6 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/439](https://github.com/salesforce/tough-cookie/pull/439)\r\n- Bump tldts from 6.1.37 to 6.1.41 in the production-dependencies group\r\nby [@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/443](https://github.com/salesforce/tough-cookie/pull/443)\r\n- Bump the dev-dependencies group with 6 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/444](https://github.com/salesforce/tough-cookie/pull/444)\r\n- upgrade typescript-eslint to 8.0.1 by\r\n[@wjhsf](https://github.com/wjhsf) in\r\n[https://github.com/salesforce/tough-cookie/pull/440](https://github.com/salesforce/tough-cookie/pull/440)\r\n- Bump the dev-dependencies group with 2 updates by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/448](https://github.com/salesforce/tough-cookie/pull/448)\r\n- Bump eslint from 8.57.0 to 9.9.1 by\r\n[@dependabot](https://github.com/dependabot) in\r\n[https://github.com/salesforce/tough-cookie/pull/449](https://github.com/salesforce/tough-cookie/pull/449)\r\n- Prepare v5 by [@colincasey](https://github.com/colincasey) in\r\n[https://github.com/salesforce/tough-cookie/pull/451](https://github.com/salesforce/tough-cookie/pull/451)\r\n\r\n#### New Contributors\r\n\r\n- [@alissonsleal](https://github.com/alissonsleal) made their\r\nfirst contribution in\r\n[https://github.com/salesforce/tough-cookie/pull/349](https://github.com/salesforce/tough-cookie/pull/349)\r\n- [@zavan](https://github.com/zavan) made their first\r\ncontribution in\r\n[https://github.com/salesforce/tough-cookie/pull/361](https://github.com/salesforce/tough-cookie/pull/361)\r\n- [@hrueger](https://github.com/hrueger) made their first\r\ncontribution in\r\n[https://github.com/salesforce/tough-cookie/pull/297](https://github.com/salesforce/tough-cookie/pull/297)\r\n\r\n**Full Changelog**:\r\nhttps://github.com/salesforce/tough-cookie/compare/v4.1.3...v5.0.0\r\n\r\n</details>\r\n\r\n---\r\n\r\n### Configuration\r\n\r\n📅 **Schedule**: Branch creation - At any time (no schedule defined),\r\nAutomerge - At any time (no schedule defined).\r\n\r\n🚦 **Automerge**: Disabled by config. Please merge this manually once you\r\nare satisfied.\r\n\r\n♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the\r\nrebase/retry checkbox.\r\n\r\n🔕 **Ignore**: Close this PR and you won't be reminded about this update\r\nagain.\r\n\r\n---\r\n\r\n- [ ] If you want to rebase/retry this PR, check\r\nthis box\r\n\r\n---\r\n\r\nThis PR has been generated by [Renovate\r\nBot](https://github.com/renovatebot/renovate).\r\n\r\n\r\n\r\nCo-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>","sha":"f712e4a47bb653136cc8ceefca08d3524dc00a4b"}}]}] BACKPORT--> Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.no…

wjhsf added 9 commits March 18, 2023 11:44

Avoid unnecessarily running compiled test files.

c207db6

Fix flaky test.

f28644e

Avoid hacky reliance on inherited property of global object.

a237cd8

Avoid needing to use resolveJsonModule.

4ff158f

Remove config that's just the default.

4118dbb

See: https://huafu.github.io/ts-jest/user/config/isolatedModules

Update tsconfig to target node 16 and only compile ./lib

78964b8

Chang dist/lib imports to just dist.

d1fc0a5

add granularity to npm scripts

7749b0d

This was referenced Mar 28, 2023

Updated dev tooling #271

Merged

Typescript support #264

Merged

Merge branch 'v5' into fix/v5-config

84ebb0f

wjhsf marked this pull request as ready for review March 30, 2023 18:28

wjhsf commented Mar 30, 2023

View reviewed changes

awaterma approved these changes Apr 17, 2023

View reviewed changes

colincasey approved these changes Apr 17, 2023

View reviewed changes

wjhsf merged commit 2bc6217 into v5 Apr 17, 2023

wjhsf deleted the fix/v5-config branch April 17, 2023 17:35

wjhsf pushed a commit that referenced this pull request Feb 8, 2024

chore: bump minimist from 1.2.5 to 1.2.6 (#269)

ec7b20e

kibanamachine mentioned this pull request Sep 18, 2024

[8.15] Update dependency tough-cookie to v5 (main) (#193107) elastic/kibana#193285

Open

kibanamachine mentioned this pull request Sep 18, 2024

[8.x] Update dependency tough-cookie to v5 (main) (#193107) elastic/kibana#193286

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[v5] Update config #269

[v5] Update config #269

wjhsf commented Mar 19, 2023 •

edited

Loading

awaterma left a comment

	export class ParameterError extends Error {
	constructor(...params: any[]) {
	super(...params);
	if (Object.setPrototypeOf) {
	Object.setPrototypeOf(this, ParameterError.prototype);
	}
	}
	}

[v5] Update config #269

[v5] Update config #269

Conversation

wjhsf commented Mar 19, 2023 • edited Loading

awaterma left a comment

Choose a reason for hiding this comment

wjhsf commented Mar 19, 2023 •

edited

Loading