Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bazelrun jvmflags, add list attribute #234

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Conversation

plaird
Copy link
Contributor

@plaird plaird commented Dec 21, 2024

Two updates:

  • New attribute bazelrun_jvm_flag_list is the new form of bazelrun_jvm_flags but is more bazel-like: it is an array of JVM args, instead of a space separated string
  • Discovered that ADD_OPENS and ADD_EXPORTS bazel run script variables were not working correctly in some cases. There was no delineation between them and JVM_FLAGS and so in some cases jvm flags were being processed as ADDs. Removed those two variables since ADDs can just be treated as additional JVM_FLAGS in a single list.

@plaird plaird merged commit afd4c9f into main Dec 21, 2024
1 check passed
@plaird plaird deleted the plaird/bazelrun_vars branch December 21, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant