Forward restricted_to and target_compatible_with attributes to rules #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Before we can merge this, we need @bhnord to sign the Salesforce Inc. Contributor License Agreement. |
|
cla has been signed |
|
Thanks for the contribution! Do you need this released ASAP, or can I collect a few more PRs? I just released 2.4.1 last night. |
|
Wow thanks for the fast response! A release would be awesome if it is not too much work, but it is up to you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Currently, the springboot rule does not forward attributes
restricted toandtarget_compatible_withto the created rules.With configurations that depend on these rules to determine compatibility, this can pose an issue.
Changes:
Forwarded attributes to custom rules