We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rules_spring
Spring JARs produced by the springboot rule are not hermetic due to the build.target in build-data.properties, which has an absolute path:
springboot
build.target
build-data.properties
build.target=/private/var/tmp/_bazel_jgriffiths/32484cc4b1bfa781e862ec83fd283f30/sandbox/darwin-sandbox/7418/execroot/my_workspace/bazel-out/darwin_arm64-fastbuild/bin/app.jar
I've compared this to the *_deploy.jar produced by java_binary which uses a relative path:
*_deploy.jar
java_binary
build.target=bazel-out/darwin_arm64-fastbuild/bin/app_deploy.jar
The text was updated successfully, but these errors were encountered:
This is caused by the --output flag to the singlejar command:
--output
rules_spring/springboot/springboot_pkg.sh
Line 316 in c9b9d94
This option is used verbatim here: https://github.com/bazelbuild/bazel/blob/2aa603bd77e5c41d546b6cd1a81e4bd5069b1149/src/tools/singlejar/output_jar.cc#L106
This is easily fixed by running the singlejar command from the rule's original working directory and passing in a relative path for --output.
singlejar
I'll submit a PR shortly.
Sorry, something went wrong.
Merge pull request #206 from jpgxs/205_fix_build_data_determinism
bc879f7
#205 Fix non-determinism in build-data.properties file
Successfully merging a pull request may close this issue.
rules_spring
Version: 2.3.2Spring JARs produced by the
springboot
rule are not hermetic due to thebuild.target
inbuild-data.properties
, which has an absolute path:I've compared this to the
*_deploy.jar
produced byjava_binary
which uses a relative path:The text was updated successfully, but these errors were encountered: