Skip to content

Commit

Permalink
provide way to pass javacopts to java_binary (#19)
Browse files Browse the repository at this point in the history
* uber_jar_javacopts

* update

* show all test output

* update
  • Loading branch information
kriscfoster authored Aug 9, 2024
1 parent ec1f8ab commit 79a5661
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,7 @@ Sometimes, you may need some logic to run before the compose test containers com
## extra_docker_compose_up_args

You can append extra arguments to the `docker compose up` command using `extra_docker_compose_up_args`. See [examples/pre-compose-up-script-test](examples/pre-compose-up-script-test) for an example.

## javacopts

You can pass `javacopts` when building the uber junit test binary using `uber_jar_javacopts`.
2 changes: 2 additions & 0 deletions docker_compose_test/docker_compose_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ def junit_docker_compose_test(
test_image_base = None,
test_srcs = [],
test_deps = [],
uber_jar_javacopts = [],
data = [],
tags = [],
size = "large",
Expand All @@ -79,6 +80,7 @@ def junit_docker_compose_test(
testonly = True,
deps = test_deps,
resources = test_deps,
javacopts = uber_jar_javacopts,
main_class = "not_used",
)

Expand Down
1 change: 0 additions & 1 deletion examples/WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ maven_install(
"org.junit.platform:junit-platform-console-standalone:1.10.0",
],
repositories = [
"https://maven.google.com",
"https://repo1.maven.org/maven2",
],
maven_install_json = "//:maven_install.json",
Expand Down

0 comments on commit 79a5661

Please sign in to comment.