fix: update dependencies and fix types for Proxy#66
Merged
nolanlawson merged 5 commits intomasterfrom Sep 8, 2021
Merged
Conversation
nolanlawson
commented
Sep 7, 2021
| footer, | ||
| file: path.join(targetDirectory, targetName) | ||
| file: path.join(targetDirectory, targetName), | ||
| exports: 'auto' |
Contributor
Author
There was a problem hiding this comment.
Does not seem to change the output file format, and suppresses a warning from Rollup.
nolanlawson
force-pushed
the
nolan/update-deps-202109
branch
from
d07cfac to
a40cf15
Compare
This was referenced Sep 7, 2021
pmdartus
approved these changes
Sep 8, 2021
Contributor
pmdartus
left a comment
pmdartus
left a comment
There was a problem hiding this comment.
Minor nitpicks otherwise LGTM.
yarn.lock
Outdated
| @@ -9,11 +9,23 @@ | |||
| dependencies: | |||
| "@babel/highlight" "^7.12.13" | |||
|
|
|||
| "@babel/code-frame@^7.14.5": | |||
Contributor
There was a problem hiding this comment.
I would recommend running yarn upgrade to get rid of the duplicate packages.
Co-authored-by: Pierre-Marie Dartus <p.dartus@salesforce.com>
Co-authored-by: Pierre-Marie Dartus <p.dartus@salesforce.com>
nolanlawson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates dependencies, most notably TypeScript which has a new definition for Proxy objects which breaks some of our existing types: microsoft/TypeScript#35594
Notably it looks like we've been assuming that
PropertyKey(which isstring | number | symbol) is fine to be used as proxy property keys, when actually the spec only allowsstring | symbol. So I added aProxyPropertyKeytype to handle this.