disabling document.all inside a sandbox #79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow up from PR #77, and after reviewing the current usage of this feature:
https://www.chromestatus.com/metrics/feature/timeline/popularity/83
I have reviewed some of the websites that are using this feature, all of them are just simply relying on the undefined nature of the value to detect something. It seems that the detection of the value being undefined is more important that the feature itself, and for that reason, we should favor the detection. In this PR, we are making the value
undefined
inside the sandbox, which means that you will never be able to access the collection itself, you have others means for that.