feat(ssr-compiler): api decorator support #4766
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekashida
commented
Nov 1, 2024
nolanlawson
requested changes
Nov 4, 2024
There was a problem hiding this comment.
We are missing some tests for what happens with @api when there is a subclass/superclass relationship.
See these Karma tests for some components that we can probably just import wholesale and use for testing.
ekashida
force-pushed
the
ekashida/api-decorator-support
branch
from
4f09b90
to
e1dfd53
Compare
nolanlawson
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Why do we need expected-ssr.html here? We can't align SSR v2 with engine-server?
There was a problem hiding this comment.
Let's do that in a different PR, I'll create a work item for it.
nolanlawson
reviewed
Nov 4, 2024
| props = __filterProperties( | ||
| props, | ||
| new Set(${/*public fields*/ is.arrayExpression}), | ||
| new Set(${/*private fields*/ is.arrayExpression}), |
There was a problem hiding this comment.
We can move the new Set() into the helper function to make this a bit cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item