Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(best-github-integration): Simplify authentication #74

Merged
merged 4 commits into from
Feb 6, 2018
Merged

fix(best-github-integration): Simplify authentication #74

merged 4 commits into from
Feb 6, 2018

Conversation

diervo
Copy link
Contributor

@diervo diervo commented Feb 6, 2018

No description provided.

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 57f2d08 | Target commit: 1473681

benchmark base(57f2d08) target(1473681) trend
object_keys.benchmark:stringify_parse 0.46 (± 0.05 ms) 0.41 (± 0.04 ms) 👍
object_keys.benchmark:deep_merge 0.47 (± 0.05 ms) 0.43 (± 0.03 ms) 👍
simple-item.benchmark:create_and_render 55.46 (± 1.13 ms) 54.11 (± 0.88 ms) 👍

@salesforce-best-lwc-internal
Copy link

Benchmark comparison

Base commit: 57f2d08 | Target commit: 3d79b6c

benchmark base(57f2d08) target(3d79b6c) trend
object_keys.benchmark:stringify_parse 0.46 (± 0.05 ms) 0.39 (± 0.04 ms) 👍
object_keys.benchmark:deep_merge 0.47 (± 0.05 ms) 0.44 (± 0.04 ms) 👍
simple-item.benchmark:create_and_render 55.46 (± 1.13 ms) 54.17 (± 0.79 ms) 👍

@diervo diervo merged commit a2f92ed into master Feb 6, 2018
@diervo diervo deleted the dval/refactorGitIntegration branch February 6, 2018 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@diervo