Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: less restrictive git remote parsing #188

Merged
merged 1 commit into from
Jul 29, 2019
Merged

fix: less restrictive git remote parsing #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/@best/config/src/__tests__/git.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

import { getGitInfo } from "../utils/git"

describe('config file resolution', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/@best/config/src/utils/git.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ function getBranch(git: SimpleGit.SimpleGit): Promise<string> {

async function getRepository(git: SimpleGit.SimpleGit): Promise<{ owner: string, repo: string }> {
const url = await git.listRemote(['--get-url']);
const matches = url.trim().match(/^.+[:/]([a-zA-Z]+)\/([a-zA-Z]+).git$/);
const matches = url.trim().match(/^.+[:/](.+)\/(.+).git$/);
if (!matches) {
throw new Error('Unable to parse git repo');
}
Expand Down