Skip to content

Commit

Permalink
feat(runner-headless): ugprade chrome (#211)
Browse files Browse the repository at this point in the history
* feat(runner-headless): ugprade chrome
* fix: upgrade docker image
  • Loading branch information
Diego Ferreiro Val authored Oct 25, 2019
1 parent af061af commit 97c0389
Show file tree
Hide file tree
Showing 9 changed files with 373 additions and 36 deletions.
8 changes: 4 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,13 @@ version: 2.1
executors:
best-executor:
docker:
- image: circleci/node:10.16.0-stretch-browsers
- image: circleci/node:lts-stretch-browsers
working_directory: ~/best

jobs:
build_and_test:
executor: best-executor

steps:
- checkout

Expand Down Expand Up @@ -40,7 +40,7 @@ jobs:

perf_and_compare:
executor: best-executor

environment:
- CUSTOM_BASH_ENV: ~/.bashrc
- CIRCLE_ENV_BROKEN: $CIRCLE_SHA1
Expand All @@ -49,7 +49,7 @@ jobs:
steps:
- attach_workspace:
at: .

- checkout

- run:
Expand Down
4 changes: 0 additions & 4 deletions docs/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,5 @@
"prismjs": "~1.16.0",
"reload": "~3.0.1",
"watch": "^1.0.2"
},
"engines": {
"node": ">=10.16.0",
"yarn": ">=1.16.0"
}
}
10 changes: 9 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,5 +73,13 @@
"packages/@best/*",
"packages/*",
"docs"
]
],
"engines": {
"node": ">=12.13.0 <13.0.0",
"yarn": ">=1.19.0 <2.0.0"
},
"volta": {
"node": "12.13.0",
"yarn": "1.19.1"
}
}
2 changes: 1 addition & 1 deletion packages/@best/builder/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"mkdirp": "~0.5.1",
"ncp": "^2.0.0",
"rimraf": "^2.6.2",
"rollup": "~1.15.5",
"rollup": "~1.25.2",
"rollup-plugin-compat": "^0.21.7",
"worker-farm": "~1.7.0"
},
Expand Down
6 changes: 4 additions & 2 deletions packages/@best/builder/src/__tests__/best-build.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,10 @@ describe('buildBenchmark', () => {
return () => {
return {
load(id) {
loaded.push(id);
return '/* empty */';
if (id.endsWith('single-file.js')) {
loaded.push(id);
return '/* empty */';
}
},
transform(src, id) {
transformed.push(id);
Expand Down
5 changes: 1 addition & 4 deletions packages/@best/frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"query-string": "^6.6.0",
"redux": "^4.0.1",
"redux-thunk": "^2.3.0",
"rollup": "^1.15.6",
"rollup": "~1.25.2",
"rollup-plugin-commonjs": "^10.0.0",
"rollup-plugin-node-resolve": "^5.0.3",
"rollup-plugin-replace": "^2.2.0",
Expand All @@ -40,9 +40,6 @@
"redux-mock-store": "^1.5.3",
"ts-node": "^8.2.0"
},
"engines": {
"node": ">=10.0.0"
},
"scripts": {
"build": "lwc-services build -m production",
"build:development": "lwc-services build",
Expand Down
2 changes: 1 addition & 1 deletion packages/@best/runner-headless/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"dependencies": {
"@best/runner-abstract": "4.0.0-alpha9",
"@best/types": "4.0.0-alpha9",
"puppeteer": "~1.17.0"
"puppeteer": "~2.0.0"
},
"files": [
"build/**/*.js"
Expand Down
4 changes: 3 additions & 1 deletion packages/@best/runtime/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

import { initializeBenchmarkConfig, getBenckmarkState } from './state';
import { runBenchmark as _runBenchmark } from './runner';
export * from './primitives';
import { describe, benchmark, beforeAll, before, afterAll, after, run } from './primitives';

declare var window: any;

Expand All @@ -33,3 +33,5 @@ window.addEventListener('load', async () => {
window.BEST_RESULTS = await runBenchmark();
}
});

export { describe, benchmark, beforeAll, before, afterAll, after, run };
Loading

0 comments on commit 97c0389

Please sign in to comment.