fix!: deprecate and remove store-aws related code

BREAKING CHANGE: Deprecate and remove `store-aws` related code.
salesforce · Nov 12, 2023 · 0d63443 · 0d63443
1 parent 8debc71
commit 0d63443
Show file tree

Hide file tree

Showing 9 changed files with 21 additions and 736 deletions.
diff --git a/docs/ci/README.md b/docs/ci/README.md
@@ -68,7 +68,7 @@ storing the artifacts on AWS.
 To use an external storage provider, pass the `--externalStorage` flag:
 
 ```sh
-best --compareStats ${BASE_COMMIT} ${TARGET_COMMIT} --externalStorage=@best/store-aws
+best --compareStats ${BASE_COMMIT} ${TARGET_COMMIT} 
 ```
 
 You must also set the `AWS_BUCKET_NAME` environment variable so Best

diff --git a/docs/configuration/README.md b/docs/configuration/README.md
@@ -56,12 +56,6 @@ config files or a local repo with Best configured.
 
 `boolean` Displays calculated `globalConfig` and project configs.
 
-### `--externalStorage`
-
-`string` Enables saving the results in an arbitrary storage system.
-Provide the external storage adapter to use. Best supports AWS with
-the `@best/store-aws` adapter.
-
 ### `--compareStats`
 
 `array` Compares the benchmarks of two commits against each other.
@@ -125,12 +119,6 @@ options.
 
 When best is not run on the main branch the snapshot is marked as temporary.
 
-### `externalStorage`
-
-`string` Allows saving the results in an arbitrary storage system.
-Specify the external storage adapter to use. Currently Best supports
-AWS with the `@best/store-aws` adapter.
-
 ### `metrics`
 
 `array` The set of metrics to capture. Currently supported options
@@ -319,8 +307,3 @@ a value for `TARGET_COMMIT` as well.
 
 `string` The target commit to be used with `--compareStats`. Set
 a value for `BASE_COMMIT` as well.
-
-### `AWS_BUCKET_NAME`
-
-`string` Name of the AWS bucket to use when `--externalStorage=@best/store-aws`
-is provided.
diff --git a/packages/@best/store-aws/package.json b/packages/@best/store-aws/package.json
diff --git a/packages/@best/store-aws/src/aws-wrapper.ts b/packages/@best/store-aws/src/aws-wrapper.ts
diff --git a/packages/@best/store-aws/src/index.ts b/packages/@best/store-aws/src/index.ts
diff --git a/packages/@best/store-aws/tsconfig.json b/packages/@best/store-aws/tsconfig.json
diff --git a/packages/@best/store-aws/typings/node-fetch.d.ts b/packages/@best/store-aws/typings/node-fetch.d.ts
diff --git a/tsconfig.json b/tsconfig.json
@@ -20,7 +20,6 @@
     { "path": "./packages/@best/runtime" },
     { "path": "./packages/@best/shared" },
     { "path": "./packages/@best/store" },
-    { "path": "./packages/@best/store-aws" },
     { "path": "./packages/@best/store-fs" },
     { "path": "./packages/@best/frontend" },
     { "path": "./packages/@best/api-db" }