Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better select styles for Firefox and Safari #128

Merged
merged 6 commits into from
Dec 15, 2015
Merged

Better select styles for Firefox and Safari #128

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d14b9df
Added .slds.form-element__select-container for better select styles i…
kevinberonilla Dec 3, 2015
179654d
Revert "Added .slds.form-element__select-container for better select …
kevinberonilla Dec 3, 2015
1356eaf
Added .slds-form-element__select-container for better select styles i…
kevinberonilla Dec 3, 2015
4bfee30
Changes per the requests of @brandonferrua
kevinberonilla Dec 4, 2015
864c702
Edited :before and :after pseudo elements to be a bit further from th…
kevinberonilla Dec 4, 2015
cfdd40a
Changes from @brandonferrua
kevinberonilla Dec 15, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 36 additions & 1 deletion ui/components/forms/flavors/select/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,39 @@
padding: $spacing-x-small;
}
}
}

&__container {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes! I hate to do this, but can you change this to a single underscore? _.

position: relative;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use 2 space indentation, please adjust throughout the file.


.#{$css-prefix}select {
-moz-appearance: none;
-webkit-appearance: none;
padding: {
left: $spacing-x-small;
right: $spacing-large;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add

&::-ms-expand {
  display: none;
}

this will help it render in IE

}

&:before,
&:after {
position: absolute;
content: "";
display: block;
right: $spacing-x-small;
width: 0;
height: 0;
border-left: 3px solid transparent;
border-right: 3px solid transparent;
}

&:before {
border-bottom: 5px solid $color-background-inverse;
top: calc((#{$line-height-button} / 2) - 6px);
}

&:after {
border-top: 5px solid $color-background-inverse;
bottom: calc((#{$line-height-button} / 2) - 6px);
}
}
}